Salvage: Fix Anim Tree blending inconsistency #53903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Marios Staikopoulos marios@staik.net
TokageItLab
force-pushed
the
fix-inconsistent-blending
branch
from
2b5e7e9 to
3ebb58c
Compare
TokageItLab
changed the title
|
Superseded again by #54205. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Marios Staikopoulos marios@staik.net
This PR is a salvage of #34134. This will break compatibility with the old NodeAdd.
Fixed #37661. And it may fixes #34694.
2021-10-17.9.17.01-1.mov
In the first blending, the translation looks strange, but this is due to a change in #53689. This requires a new implementation of blending when no track exists, separately from this PR.
The second blending also looks broken at first look, but since the similar pose is applied twice, which is the correct behavior. Moreover, this change makes the proposal godotengine/godot-proposals#2700 worthwhile in conjunction with #53765.
In other words, godotengine/godot-proposals#2700 mentioned a problem with the previous animation system which the base pose for extracting additive animations was completely fixed on import, but this has been removed by #53765. The correct extraction of additive animation can now be done by implementing NodeSub or by setting the base pose as an optional parameter in NodeAdd.