Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS / iOS] Use storage buffers instead of unsupported images for the volumetric fog on MoltenVK. #55281

Merged
merged 1 commit into from
Nov 24, 2021
Merged

[macOS / iOS] Use storage buffers instead of unsupported images for the volumetric fog on MoltenVK. #55281

merged 1 commit into from
Nov 24, 2021

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Nov 24, 2021 •
edited
Loading

Metal and MoltenVK do not support atomic operations on images, so use storage buffers instead.

Fixes fog shader compilation errors on macOS - #53353 (comment)

Screenshot 2021-11-24 at 09 28 27

@bruvzg bruvzg added this to the 4.0 milestone Nov 24, 2021
@bruvzg bruvzg requested a review from a team as a code owner November 24, 2021 07:29
@bruvzg bruvzg mentioned this pull request Nov 24, 2021
Merged
@bruvzg bruvzg requested a review from clayjohn November 24, 2021 08:33
clayjohn
clayjohn approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test as I don't have an Apple device, but the implementation looks good!

@akien-mga akien-mga merged commit 3e33006 into godotengine:master Nov 24, 2021
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the mvk_fog_volumes branch November 24, 2021 16:09
@bruvzg bruvzg mentioned this pull request Nov 25, 2021
Merged
@Geometror Geometror mentioned this pull request Dec 3, 2021
Closed
@bruvzg bruvzg mentioned this pull request Feb 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug needs testing platform:ios platform:macos topic:porting topic:rendering topic:3d
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bruvzg @akien-mga @clayjohn