Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix flickering issues with low processor mode on Android #59606

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Mar 28, 2022

As pointed out by @Relintai in #55604 (comment), the cause of the flickers when enabling low processor mode is that the framebuffers are swapped automatically even when nothing is rendered.

To resolve the issue, I forked GLSurfaceView so that the Godot Android logic can specify when the framebuffers should be swapped.

Fixes #19304

@m4gr3d m4gr3d added this to the 3.5 milestone Mar 28, 2022
@m4gr3d m4gr3d requested review from a team as code owners March 28, 2022 01:05
@m4gr3d m4gr3d force-pushed the fix_low_processor_mode_3x branch 2 times, most recently from c9160a6 to f921b62 Compare March 28, 2022 01:34
@m4gr3d
Copy link
Contributor Author

m4gr3d commented Mar 28, 2022

@akien-mga Given we're forking two files, can we disable the static checks on them?

@akien-mga
Copy link
Member

@akien-mga Given we're forking two files, can we disable the static checks on them?

You can add // clang-format off in the file and everything after the comment will not be formatted.

Make sure to identify the downstream changes clearly in those files so that we know what is Godot specific.

@akien-mga akien-mga requested a review from RandomShaper March 28, 2022 08:29
Relintai added a commit to Relintai/pandemonium_engine that referenced this pull request Mar 28, 2022
@m4gr3d m4gr3d force-pushed the fix_low_processor_mode_3x branch from f921b62 to 548be06 Compare March 28, 2022 14:35
@m4gr3d
Copy link
Contributor Author

m4gr3d commented Mar 28, 2022

@akien-mga Given we're forking two files, can we disable the static checks on them?

You can add // clang-format off in the file and everything after the comment will not be formatted.

Make sure to identify the downstream changes clearly in those files so that we know what is Godot specific.

@akien-mga Done!

@m4gr3d m4gr3d force-pushed the fix_low_processor_mode_3x branch 2 times, most recently from f1fbe34 to 6cc41ac Compare March 28, 2022 17:18
@m4gr3d m4gr3d requested a review from a team as a code owner March 28, 2022 17:18
@m4gr3d m4gr3d force-pushed the fix_low_processor_mode_3x branch 3 times, most recently from 32d72c7 to 4c7b889 Compare March 28, 2022 20:50
Copy link
Member

@RandomShaper RandomShaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to say beyond what I've commented in the PR for 4.0.

@m4gr3d m4gr3d force-pushed the fix_low_processor_mode_3x branch from 4c7b889 to 8ca32d1 Compare March 29, 2022 19:17
@akien-mga akien-mga merged commit 3c0d325 into godotengine:3.x Mar 29, 2022
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the fix_low_processor_mode_3x branch March 29, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants