Color Pickers Respect Default Editor Settings

[Guh-Feng]

Updated editor_node with set_color_picker function called by color pickers throughout Godot to respect the editor's settings.
Another attempt to fix #57154.
Implemented changes noted in #57402 and rewrote certain color pickers to match the function call and keep everything consistent.

[KoBeWi]

Looks good overall, but you shouldn't change ColorPicker nodes to ColorPickerButtons as they won't work correctly.

Instead you can manually setup the picker, e.g. here

godot/editor/plugins/script_text_editor.cpp

Lines 1177 to 1179 in 03765b2

	case EDIT_PICK_COLOR: {
	color_panel->popup();
	} break;

here

godot/scene/gui/gradient_edit.cpp

Lines 75 to 80 in 03765b2

	if (show_above) {
	popup->set_position(get_screen_position() - Vector2(0, minsize.y));
	} else {
	popup->set_position(get_screen_position() + Vector2(0, get_size().y));
	}
	popup->popup();

etc.
(you can also connect to the custom popups there)

[Guh-Feng]

Made changes from the recommendations. Things to note that I forgot to mention initially, I looked into fire-forge's suggestion for making everything use the same color picker. It seems just a little out of the scope of what I can do but I might consider working on it in the future. I also had a different perspective in consolidating the script used to sync the color picker settings into a single method. It might be a bandage solution but it could be an easier way to achieve the same goal. I'd like some feedback on the idea.

Also, I reverted the ColorPicker variables and adjusted the connections appropriately but kept them in the original locations to avoid calling it repeatedly.

[KoBeWi]

Looks good now. You need to squash the commits.

[KoBeWi]

Ah now I noticed that GradientEdit isn't editor class, so it can't include editor-related code. You need to add a public method that returns the popup and then setup it in gradient editor plugin.

Also style checks failed, so you need to run clang-format.

[akien-mga]

Needs a rebase/rework after #62075.

[KoBeWi]

Suggested change

	GradientEdit::get_popup()->connect("about_to_popup", callable_mp(EditorNode::get_singleton(), &EditorNode::setup_color_picker), varray(GradientEdit::get_picker()));
	get_popup()->connect("about_to_popup", callable_mp(EditorNode::get_singleton(), &EditorNode::setup_color_picker), varray(GradientEdit::get_picker()));

Not necessary.

[KoBeWi]

The rebase should be easy, just initialization code has changed from

godot/editor/editor_properties.cpp

Lines 3012 to 3020 in 31745a8

	int default_color_mode = EDITOR_GET("interface/inspector/default_color_picker_mode");
	if (default_color_mode == 1) {
	picker->get_picker()->set_hsv_mode(true);
	} else if (default_color_mode == 2) {
	picker->get_picker()->set_raw_mode(true);
	}
	int picker_shape = EDITOR_GET("interface/inspector/default_color_picker_shape");
	picker->get_picker()->set_picker_shape((ColorPicker::PickerShapeType)picker_shape);

to

godot/editor/editor_properties.cpp

Lines 3012 to 3015 in ca18a02

	int default_color_mode = EDITOR_GET("interface/inspector/default_color_picker_mode");
	picker->get_picker()->set_color_mode((ColorPicker::ColorModeType)default_color_mode);
	int picker_shape = EDITOR_GET("interface/inspector/default_color_picker_shape");
	picker->get_picker()->set_picker_shape((ColorPicker::PickerShapeType)picker_shape);

[Guh-Feng]

The rebase should be easy, just initialization code has changed from...

Do I add back the _picker_created function with these suggested changes?

[KoBeWi]

You need to update your setup_color_picker() function.

[Guh-Feng]

Sorry that it got a little messy, but I cleaned everything up and I think all the changes appropriately accommodate the rebase.

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉