fix switching RAW mode to RGB mode issue

[KuaiDain]

fixes #62894

return next_power_of_2(MAX(255, color.components[idx] * 255.0)) - 1;

when result of color.components[idx] * 255.0 beyond 255, this issue will happen, so i modified this function as other mode

[KoBeWi]

Doesn't this always clamp the value to 255? It means your color is truncated when you switch from RAW to RGB. Not sure if it's desired 🤔

[fire]

You can have different "intensity" value that is multiplied with a rgba8 to store the original value, but converting values outside of 0 to 1 to RGBA8 is a lossy conversion.

Would like some opinions.

[KuaiDain]

thanks for your advice
i think this issue again, when i change value in RGB mode, it will store value/255.0 back to color, so rgba is in range 0 to 1,

Color ColorModeRGB::get_color() const {
	Vector<float> values = color_picker->get_active_slider_values();
	Color color;
	for (int i = 0; i < 4; i++) {
		color.components[i] = values[i] / 255.0;
	}
	return color;
}

except RAW mode, other mode do a calculation, then store back to color

Color ColorModeRAW::get_color() const {
	Vector<float> values = color_picker->get_active_slider_values();
	Color color;
	for (int i = 0; i < 4; i++) {
		color.components[i] = values[i];
	}
	return color;
}

float slider_max[4] = { 100, 100, 100, 1 }; this line cause that we can store value beyond 1 back to color, so i change it to float slider_max[4] = { 1, 1, 1, 1 };

[AThousandShips]

See also:

• Fix ColorPicker's RAW mode colors and values #88072