Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement keep_screen_on for Windows #63882

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Implement keep_screen_on for Windows #63882

merged 1 commit into from
Aug 5, 2022

Conversation

RedMser
Copy link
Contributor

@RedMser RedMser commented Aug 3, 2022 •
edited
Loading

Fixes #63881

Includes a nice reason string when viewing power information (e.g. via command line):

> powercfg /requests
DISPLAY:
[PROCESS] \Device\HarddiskVolume7\Sources\godot\bin\godot.windows.tools.64.exe
Godot Engine running with display/window/energy_saving/keep_screen_on = true

@RedMser RedMser requested review from a team as code owners August 3, 2022 16:41
@Calinou Calinou added this to the 4.0 milestone Aug 3, 2022
@RedMser RedMser force-pushed the keep-screen-on-windows branch 3 times, most recently from 45718b9 to 913f91e Compare August 4, 2022 00:17
@akien-mga
Copy link
Member

akien-mga commented Aug 4, 2022 •
edited
Loading

@bruvzg Is this relevant for macOS?

@bruvzg

This comment was marked as outdated.

Sign in to view
@bruvzg
Copy link
Member

bruvzg commented Aug 4, 2022

Is thus relevant for macOS?

Godot is preventing sleep, but not a screensaver, so it is relevant. I'll take a look.

@bruvzg
Copy link
Member

bruvzg commented Aug 4, 2022

Godot is preventing sleep, but not a screensaver, so it is relevant. I'll take a look.

#63900

bruvzg
bruvzg reviewed Aug 4, 2022
View reviewed changes
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows code seems fine to me.

platform/windows/display_server_windows.cpp Outdated Show resolved Hide resolved
@RedMser
Copy link
Contributor Author

RedMser commented Aug 5, 2022

Should be ready now 👍

@akien-mga akien-mga merged commit 04a66e1 into godotengine:master Aug 5, 2022
@akien-mga
Copy link
Member

Thanks!

@RedMser RedMser mentioned this pull request Aug 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitsawer bitsawer bitsawer left review comments

@akien-mga akien-mga akien-mga approved these changes

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
enhancement platform:windows