Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix issue preventing the Android Editor from displaying the project content #64420

Merged
merged 3 commits into from
Aug 15, 2022

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Aug 15, 2022

The issue was causing by a bug within the logic for FileAccessFilesystemJAndroid#eof_reached() causing that value to remain false after the eof was reached.
This in turn caused an infinite loop in the file scanner preventing the project's content from showing up.

Fix #63981

@m4gr3d m4gr3d added bug platform:android cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Aug 15, 2022
@m4gr3d m4gr3d added this to the 3.6 milestone Aug 15, 2022
@m4gr3d m4gr3d requested a review from a team as a code owner August 15, 2022 07:43
m4gr3d added 2 commits August 15, 2022 02:21
…ontent

The issue was causing by a bug within the logic for `FileAccessFilesystemJAndroid#eof_reached()` causing that value to remain false after the eof was reached.
This in turn caused an infinite loop in the file scanner preventing the project's content from showing up.
The functionality is unavailable on Android (requires export capability) and unnecessarily consumes resources
@m4gr3d m4gr3d force-pushed the investigate_read_write_access_loss_3x branch from abd4fe7 to 3ac6b6a Compare August 15, 2022 09:30
@m4gr3d m4gr3d requested a review from a team as a code owner August 15, 2022 09:30
@m4gr3d m4gr3d merged commit 989d599 into godotengine:3.x Aug 15, 2022
@m4gr3d m4gr3d deleted the investigate_read_write_access_loss_3x branch August 15, 2022 20:19
@akien-mga
Copy link
Member

Cherry-picked for 3.5.1.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants