GDScript: Fix repeated _ are allowed after decimal point
#73203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not familiar with the tokenizer and I don't trust myself to review code right now, but it'd be great to add unit tests for these! :) |
|
The PR works well. I agree with @anvilfolk for the need of unit tests and @joao-pedro-braz for the error message that could confuse users. Other than that, once fixed, this will be good to go. |
dalexeev
force-pushed
the
gds-fix-num-literal
branch
from
7131734 to
fba8cbe
Compare
akien-mga
approved these changes
Jun 15, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing check to disallow literals like
10.12___3. This is already checked for parts before decimal point and aftere.Closes #73804.