Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix highlighting of hex numbers with separators #81039

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Fix highlighting of hex numbers with separators #81039

merged 1 commit into from
Aug 28, 2023

Conversation

MewPurPur
Copy link
Contributor

image

^ Fix this

@MewPurPur MewPurPur requested a review from a team as a code owner August 27, 2023 11:44
@AThousandShips AThousandShips added this to the 4.2 milestone Aug 27, 2023
adamscott
adamscott approved these changes Aug 27, 2023
View reviewed changes
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

It works!

@dalexeev
Copy link
Member

I noticed this in #73203 but forgot to fix it, thank you. Can you please edit line 330 by the way:

-    !(str[j] == '.' && (prev_is_digit || (!prev_is_binary_op && (j > 0 && (str[j - 1] == '-' || str[j - 1] == '+' || str[j - 1] == '~'))))) &&
+    !(str[j] == '.' && (prev_is_digit || (!prev_is_binary_op && (j > 0 && (str[j - 1] == '_' || str[j - 1] == '-' || str[j - 1] == '+' || str[j - 1] == '~'))))) &&

This is for . after _ (for example 1_.2) is highlighted in number color.

@MewPurPur MewPurPur force-pushed the fix-hex-number-highlighting-after-separator branch from 1b0d399 to d394624 Compare August 28, 2023 06:53
@MewPurPur
Copy link
Contributor Author

Doned

@akien-mga akien-mga merged commit fc37fd7 into godotengine:master Aug 28, 2023
@akien-mga
Copy link
Member

Thanks!

@MewPurPur MewPurPur deleted the fix-hex-number-highlighting-after-separator branch August 28, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexeev dalexeev dalexeev approved these changes

@adamscott adamscott adamscott approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:gdscript
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@MewPurPur @dalexeev @akien-mga @adamscott @AThousandShips