Fix file permissions for the web platform (affects every Unix-like platform) #79866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamscott
added
bug
platform:linuxbsd
platform:web
platform:ios
platform:android
platform:macos
cherrypick:4.0
cherrypick:4.1
|
Added as label each Unix-like platform. |
adamscott
changed the title
bruvzg
requested changes
Jul 25, 2023
adamscott
force-pushed
the
fix-file-permissions-web
branch
from
b6ddb48 to
b6faccc
Compare
bruvzg
approved these changes
Jul 25, 2023
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79594.
umask()is now called only once and will be applied tofchmod()automatically as it has been called just before.umask()was removed, see bruvzg's comment.With this PR, the web platform now imports correctly files.
If needed, a MRP is simply creating a new project from the project explorer: if the icon is correctly imported, the fix worked.