Remove GPU readback from NoiseTexture3D.get_format()
#80407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
added
bug
topic:rendering
performance
cherrypick:4.1
|
Thanks! |
This was referenced Aug 8, 2023
akien-mga
changed the title
NoiseTexture3D.get_format()
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I caught this issue while reviewing another PR. When accessing the format of the NoiseTexture3D it was requesting a GPU->CPU copy of the texture data, then throwing away the texture data and only using the format. This is not only an expensive operation, it also causes a full GPU->CPU sync making it very expensive to call at runtime.
This is a very low risk bug fix
Bugsquad edit: