Fix modifying base script exports not propagating to derived scripts #83123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
changed the title
|
Could you update the commit message to match our preferred style? https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#format-your-commit-messages-with-readability-in-mind |
…e opened property editor This patch fixes the user having to navigate away from the selected node which has the derived script attached and back to see the changes of the base script exports reflected in the property editor.
astillich
force-pushed
the
82998-propagate-base-class-exports
branch
from
f6a063a to
99f8751
Compare
AThousandShips
approved these changes
Oct 16, 2023
|
Thanks! I was about to thank you for your first contribution, but then I looked at the history and found your previous one 9 years ago... that's a big one! #1002 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #82998 by triggering an update in derived scripts if an export changes on of the base scripts in the hierarchy. Tested over three levels of inheritance with editing the default value and adding / removing exports.
Bugsquad edit: fixes #82998