Add an extra backbuffer color texture that can be used when an upscaler is in use. #83192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase your branch to solve CI |
DarioSamo
force-pushed
the
fsr2-shader-backbuffer-fix
branch
from
a2e7887 to
325623d
Compare
|
Oops, guess I didn't make it in time yesterday when I branched off master. Hopefully it works now. |
|
My bad seems you did catch that one, unsure why it fails now |
|
My attempt at fixing this CI issue didn't work. Still don't know why it's randomly failing. Manually restarting it once all builds have completed might fix it. |
…er is in use. Fixes issue godotengine#83152. Due to how BLUR_0 is reused for multiple purposes and requires being at native resolution for some post-processing effects to work, FSR2 will use an alternate texture at internal size to use as the screen texture read by shaders instead. The rendering pipeline will prefer using this texture if it exists.
DarioSamo
force-pushed
the
fsr2-shader-backbuffer-fix
branch
from
325623d to
4890e96
Compare
clayjohn
approved these changes
Oct 19, 2023
| // dedicated backbuffer copy texture instead if the blur texture is not an option so shader effects work correctly. | ||
| Size2i target_size = rb->get_target_size(); | ||
| bool using_fsr2 = (rb->get_scaling_3d_mode() == RS::VIEWPORT_SCALING_3D_MODE_FSR2); | ||
| bool internal_size_matches = (size.width == target_size.width) && (size.height == target_size.height); |
There was a problem hiding this comment.
Suggested change
| bool internal_size_matches = (size.width == target_size.width) && (size.height == target_size.height); | |
| bool internal_size_matches = (size == target_size); |
There was a problem hiding this comment.
Missed this when merging from command line. Could be tweaked next time surrounding code is modified.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83152. Due to how BLUR_0 is reused for multiple purposes and requires being at native resolution for some post-processing effects to work, FSR2 will use an alternate texture at internal size to use as the screen texture read by shaders instead. The rendering pipeline will prefer using this texture if it exists.
Anything that used screen textures inside a custom shader was affected when FSR2 was enabled with a resolution scale below 1.0.