Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it a matter of replacing
get_physics_process_delta_time()
withget_process_delta_time()
here, without moving the code around?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be, but I wanted to keep it consistent with #87621, since canvas_item_editor_plugin.cpp doesn't have a notification for process. I thought it would be strange to make one just for this functionality, when either/or would work.Edit: The fact that anything is in physics process that's unrelated to physics is the real strange thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this does beg the question of why the stuff in canvas plugin is in physics process and not just process?
Edit: And stuff in Node3D plugin as well. It all kind of seems arbitrary and possibly has some other unknown side effects. What does any of this stuff have to do with physics? We can change the physics step, so it's not like the default of 60 is some kind of requirement for anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'll need to dig into this whole issue. It seems like it has the potential to affect several things. For now, I've applied your suggestion, since it makes a lot more sense given what I said above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened a separate issue for this: #87885