Add Security Warnings to str_to_var and var_to_str Documentation #88112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From what I could see only SSAO & SSIL were affected when they both
call:
int zero[1] = { 0 };
RD::get_singleton()->buffer_update(ssao.importance_map_load_counter, 0,
sizeof(uint32_t), &zero, 0);
int zero[1] = { 0 };
RD::get_singleton()->buffer_update(ssil.importance_map_load_counter, 0,
sizeof(uint32_t), &zero, 0);
Also documented what setup_command_buffer & draw_command_buffer are for.
Fixes missing NavigationLink property updates in constructor.
Fixes missing NavigationAgent property updates in constructor.
Fixes missing NavigationObstacle property updates in constructor.
But not allow dropping inside the scene tree editor.
This is a minor usability tweak. The light functions replace the default ones, so even if empty they will avoid the current shader to have proper lighting and users will have no idea why. Code was changed to have the shader function commented by default, indicating that uncommenting replaces the default function.
Print error and default to forward plus
- Mention the Use Nearest Mipmap Filter project setting. - Fix nearest mipmap claiming to always use bilinear filtering (it uses trilinear filtering by default, like linear mipmap).
…e selector This applies to both GPUParticles3D and CPUParticles3D, as CPUParticles3DEditor inherits from GPUParticles3DEditorBase.
Also fix bug in creation of vertex input mask
Fixes NavigationRegion2D transform update.
Also updates some error messages related to this kind of check across the codebase.
|
You need to rebase your branch see here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding warnings to str_to_var and var_to_str in the docs because I found out "str_to_var" can run code without warning when I checked the source code and tested it myself.
This wasn't clear before. The warnings are to help other developers know about this risk.