[Doc] Fix some incorrect uses of a/an
#89444
Conversation
AThousandShips
added
bug
documentation
cherrypick:4.1
| @@ -124,7 +124,7 @@ | |||
| <param index="0" name="nd_threshold" type="float" /> | |||
| <param index="1" name="target_index_count" type="int" default="3" /> | |||
| <description> | |||
| Generates a LOD for a given [param nd_threshold] in linear units (square root of quadric error metric), using at most [param target_index_count] indices. | |||
| Generates an LOD for a given [param nd_threshold] in linear units (square root of quadric error metric), using at most [param target_index_count] indices. | |||
There was a problem hiding this comment.
I would say "lod" as a word, but I guess "el oh dee" is a valid form too.
Only "reference" I could find from a quick search is this shady looking https://www.spellchecker.net/lod
There was a problem hiding this comment.
I'll restore too, though I'd read it as an acronym
There was a problem hiding this comment.
Well I'm not sure on that one, might be worth polling on #rendering to see what folks are used to hearing :)
There was a problem hiding this comment.
Given the current trend for the poll I added back the "LOD" cases, will squash or drop depending
There was a problem hiding this comment.
I think you can go ahead and squash :)
AThousandShips
force-pushed
the
article_fix
branch
from
eca1b78
to
ba7b2f3
Compare
AThousandShips
force-pushed
the
article_fix
branch
from
0451112
to
24c9d44
Compare
| @@ -1099,14 +1099,14 @@ | |||
| <method name="rid_allocate_id"> | |||
| <return type="int" /> | |||
| <description> | |||
| Allocates a unique ID which can be used by the implementation to construct a RID. This is used mainly from native extensions to implement servers. | |||
There was a problem hiding this comment.
This does not feel right, can you elaborate on what I missed?
I would replace all of these RID over the place with a direct reference to the RID, but that's for later.
It feels so wrong to me I came back to this message just to try to wrap my head around it. To me, RID reads as it is written. And the acronym stands for "Resource Identifier", not "Identifier Resource".
There was a problem hiding this comment.
It's "ar I dee", not "rid", this isn't about anything else than grammar, the article just depends on if it proceeds a vowel sounds or not
|
Thanks! |
|
Thank you! |
akien-mga
removed
cherrypick:4.1
Treating "LOD" as being pronounced "eLODee", otherwise this is largely fixing cases spelled correctly elsewhere