-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Fix some incorrect uses of a/an
#89444
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -124,7 +124,7 @@ | |
<param index="0" name="nd_threshold" type="float" /> | ||
<param index="1" name="target_index_count" type="int" default="3" /> | ||
<description> | ||
Generates a LOD for a given [param nd_threshold] in linear units (square root of quadric error metric), using at most [param target_index_count] indices. | ||
Generates an LOD for a given [param nd_threshold] in linear units (square root of quadric error metric), using at most [param target_index_count] indices. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would say "lod" as a word, but I guess "el oh dee" is a valid form too. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll restore too, though I'd read it as an acronym There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well I'm not sure on that one, might be worth polling on #rendering to see what folks are used to hearing :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Given the current trend for the poll I added back the "LOD" cases, will squash or drop depending There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you can go ahead and squash :) |
||
</description> | ||
</method> | ||
<method name="generate_normals"> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not feel right, can you elaborate on what I missed?
I would replace all of these RID over the place with a direct reference to the RID, but that's for later.
It feels so wrong to me I came back to this message just to try to wrap my head around it. To me, RID reads as it is written. And the acronym stands for "Resource Identifier", not "Identifier Resource".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's "ar I dee", not "rid", this isn't about anything else than grammar, the article just depends on if it proceeds a vowel sounds or not