-
-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Scrolling
signal when scrolling with middle mouse on RichTextLabel
or ScrollContainer
#90988
Conversation
c36b87b
to
9dbf384
Compare
Amended PR. Added I feel this is more clear and consistent behaviour. |
9dbf384
to
fd43eb8
Compare
Scrolling
signal when scrolling with middle mouse on RichTextLabel
or ScrollContainer
Scrolling
signal when scrolling with middle mouse on RichTextLabel
or ScrollContainer
fd43eb8
to
3aec2cc
Compare
The scroll signal is not emitted when dragging. |
ScrollContainer has some |
Guess I was unsure about touch events, since they kinda do a bit of momentum and physics rather than direct physical interaction, but I suppose it's best to change them. |
3aec2cc
to
d68352b
Compare
There seems to be another bug. When you scroll continuously using mouse wheel, the signal will be emitted even if no scrolling happens. EDIT: #90988 (comment) |
…xtLabel/ScrollContainer
d68352b
to
30356a4
Compare
Fixed. |
Thanks! |
Fixes #46421
Added new function to
ScrollBar
so that the bar could be scrolled in a way that would emit ascrolling
signal. EditedRichTextLabel
andScrollContainer
to use such functionality so scrolling either using the mouse scrollwheel would cause the signal to be emitted from theScrollBar