Downsample textures on import if necessary for technical reasons #93440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
import-size-limit-downsample-if-necessary
branch
from
344a003 to
d53835c
Compare
Mickeon
reviewed
Jun 21, 2024
Calinou
force-pushed
the
import-size-limit-downsample-if-necessary
branch
from
d53835c to
8b12985
Compare
Compression formats are limited to various sizes (16383×16383 for WebP, 16384×16384 for Basis Universal). If the size is exceeded, the texture fails to import. To avoid this, textures are now downsampled with a warning printed when necessary. The warning is not printed if the user has specified a size limit and the size limit is being honored. This also allows setting Size Limit up to 16383 pixels (the lowest common denominator out of all compression modes), instead of being limited to 4096 pixels.
Calinou
force-pushed
the
import-size-limit-downsample-if-necessary
branch
from
8b12985 to
cd7a708
Compare
Mickeon
approved these changes
Jun 22, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compression formats are limited to various sizes (16383×16383 for WebP1, 16384×16384 for Basis Universal). If the size is exceeded, the texture fails to import. To avoid this, textures are now downsampled with a warning printed when necessary.
The warning is not printed if the user has specified a size limit and the size limit is being honored.
This also allows setting Size Limit up to 16383 pixels (the lowest common denominator out of all compression modes), instead of being limited to 4096 pixels.
Preview
Footnotes
Lossless compression mode switches to PNG for textures larger than 16383 pixels on either axis, so it's not limited to 16383 pixels. ↩