-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Use Color and Use HDR properties to LightmapGI #50574
base: master
Are you sure you want to change the base?
Conversation
I think this is a misunderstanding of how lightmaps work in Godot 4.0, but may be good to improve the usability on this. |
What do you mean by misunderstanding? Changing an image's pixel format will reduce its size on disk. I don't think there's anything more involved 🙂 |
bf0a669
to
e4c6327
Compare
Rebased and tested again, it works as expected. The file size differentials are even greater now, since we can use lossless WebP for LDR lightmaps instead of PNG 🙂 |
e4c6327
to
91a6b93
Compare
cce59c6
to
efd3559
Compare
efd3559
to
e6f7a08
Compare
Colored lightmaps and HDR lightmaps can be disabled to reduce file size, which is useful for mobile/web platforms. File size comparison in a given 3D scene: - HDR enabled, color enabled (default): 9.80 MB - HDR enabled, color disabled: 3.32 MB (3× smaller) - HDR disabled, color enabled: 902 KB (11× smaller) - HDR disabled, color disabled: 471 KB (21× smaller)
e6f7a08
to
316627a
Compare
Some things to consider: |
Follow-up to #50572.
Colored lightmaps and HDR lightmaps can be disabled to reduce file size, which is useful for mobile/web platforms.
This closes #50569 and closes #50570.
File size comparison in a given 3D scene: