[Windows] Fix OS.open_dynamic_library
#96235
Merged
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
commented
Aug 28, 2024
| @@ -260,7 +260,7 @@ bool get_dotnet_self_registered_dir(String &r_dotnet_root) { | |||
| return false; | |||
| } | |||
|
|
|||
| r_dotnet_root = String::utf16((const char16_t *)buffer.ptr()); | |||
| r_dotnet_root = String::utf16((const char16_t *)buffer.ptr()).replace("\\", "/"); | |||
There was a problem hiding this comment.
Note: this change is not necessary (everything will work without it), but makes path cleaner (had mixed \ and /).
akien-mga
approved these changes
Aug 28, 2024
|
Thanks! |
akien-mga
changed the title
OS.open_dynamic_library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incorrect rebase of #91902 after #96192 (dll directory was used instead of name).
Fixed #96231