-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android Editor] Update the options for launching the Play window in PiP mode #96340
Conversation
cc @arutemu |
@m4gr3d Thank you! PiP works like a charm :) However, there is an issue that may be out of the scope of this exact change - the hardware controls (keyboard/gamepad) do not work with the game running in PiP mode. I understand that touch controls are not supposed to work in PiP mode, as stated in #95700. UPD. |
Thanks! @m4gr3d See above question about gamepad input. Should that be filed in a new issue? |
@arutemu @akien-mga I checked and it's an Android limitation. The content in the window running in PiP mode doesn't get any input events, the only exception being the PiP buttons used to restore full screen or close the PiP window, which matches the behavior you're seeing. PiP mode was originally created for media watching while multi-tasking so those restrictions make sense in that context. Hopefully future versions of Android will expand the input capabilities for PiP windows. |
@m4gr3d than you for the reply! It's a bit sad result, to be fair, as it makes PiP mode almost useless for any dynamic scenes. Just one more question - maybe there is some workaround for passing the HW inputs from the editor to the PiP window? Or any other way to update the game data? |
Something like this will be needed for embedding the game window within the editor. It shouldn't be too difficult to implement right now if all you need is input forwarding. Touch and mouse motion events might be more difficult due to the captured and confined mouse modes, but keyboard and gamepad1 should be straightforward. Footnotes
|
Follow-up from #95700 (comment)
This PR adds a new mode to launch the Play window directly in picture-in-picture (PiP) mode.
Screen_Recording_20240830_103034.mp4