Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android Editor] Add support for launching the Play window in PiP mode #95700

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Aug 17, 2024

Adds support for launching the Play window in picture-in-picture (PiP) mode, which provides additional flexibility when developing and running the game at the same time especially for phones with limited screen estate.

Screen_Recording_20240817_081346.mp4

Note:

  • The Play window in PiP mode does not take touch inputs; interaction using touch inputs requires restoring the Play window to full screen.
  • When PiP is enabled, running the game with breakpoints enabled will launch directly in PiP mode
Screen_Recording_20240817_081736.mp4
Screen_Recording_20240827_061351.mp4

@m4gr3d m4gr3d added this to the 4.4 milestone Aug 17, 2024
@m4gr3d m4gr3d force-pushed the add_pip_support_to_game_window branch from 8f51ae1 to cc6bd10 Compare August 17, 2024 15:43
@m4gr3d m4gr3d force-pushed the add_pip_support_to_game_window branch 3 times, most recently from dbf510c to 664c3ef Compare August 27, 2024 12:51
@m4gr3d m4gr3d marked this pull request as ready for review August 27, 2024 13:17
@m4gr3d m4gr3d requested review from a team as code owners August 27, 2024 13:17
@m4gr3d m4gr3d force-pushed the add_pip_support_to_game_window branch from 664c3ef to 961394a Compare August 28, 2024 10:19
@akien-mga akien-mga merged commit 60765be into godotengine:master Aug 28, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the add_pip_support_to_game_window branch August 28, 2024 13:34
@arutemu
Copy link

arutemu commented Aug 30, 2024

I am sorry if it's not a good place to ask questions, especially since the changes are already merged.
But is there an option to launch the game in PiP mode by default? (Which would be one of the most useful launch options)

Despite a number of available setting options, none seems to be doing this.

@m4gr3d
Copy link
Contributor Author

m4gr3d commented Aug 30, 2024

I am sorry if it's not a good place to ask questions, especially since the changes are already merged. But is there an option to launch the game in PiP mode by default? (Which would be one of the most useful launch options)

Despite a number of available setting options, none seems to be doing this.

@arutemu I had considered this but at the time couldn't settle on the proper UX to make this happen. Thinking on it some more, launching in PiP mode could be an option in the run/window_placement/android_window editor setting.

I'll push a PR with those changes.

@arutemu
Copy link

arutemu commented Aug 30, 2024

@m4gr3d thank you for the update. Would be glad to test it :)

Just to clarify - such feature may not be useful on the devices with small displays, but could be really great on android tablets.
Especially since android's implementation of the windowed apps is quite... not polished, to be honest.

Also, small question - is it fine to reach with similar QoL/usability ideas via github comments, or is there some more suitable place?

@m4gr3d
Copy link
Contributor Author

m4gr3d commented Aug 30, 2024

Just to clarify - such feature may not be useful on the devices with small displays, but could be really great on android tablets.
Especially since android's implementation of the windowed apps is quite... not polished, to be honest.

Note that for tablets, you can also enable the Side-by-side with Editor option in the editor settings under the Run -> Window Placement -> Android Window section.

Also, small question - is it fine to reach with similar QoL/usability ideas via github comments, or is there some more suitable place?

If the comments are within the scope to the PR being merged, then posting on the PR is fine.

For bug reports, you should create a new issue through the project issue page.
For new feature proposals, you should submit feature proposals on the Godot proposals repository.

Hope that helps!

@Davinci4
Copy link

Is there any chance that you Could you sent me the apk with the commuts you made ?

@m4gr3d
Copy link
Contributor Author

m4gr3d commented Sep 28, 2024

Is there any chance that you Could you sent me the apk with the commuts you made ?

@Davinci4 these changes are available in the latest 4.4 dev2 builds. You can get access to that build from the play store through https://play.google.com/apps/testing/org.godotengine.editor.v4.

In addition the apks for each release can be found in https://github.com/godotengine/godot-builds/releases.

And lastly the editor apks for each PR can be found under the checks tab for that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release enhancement platform:android topic:editor topic:porting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android editor freezes after script error in project due to not switching to the editor view automatically
4 participants