-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android Editor] Add support for launching the Play window in PiP mode #95700
[Android Editor] Add support for launching the Play window in PiP mode #95700
Conversation
8f51ae1
to
cc6bd10
Compare
dbf510c
to
664c3ef
Compare
664c3ef
to
961394a
Compare
Thanks! |
I am sorry if it's not a good place to ask questions, especially since the changes are already merged. Despite a number of available setting options, none seems to be doing this. |
@arutemu I had considered this but at the time couldn't settle on the proper UX to make this happen. Thinking on it some more, launching in PiP mode could be an option in the I'll push a PR with those changes. |
@m4gr3d thank you for the update. Would be glad to test it :) Just to clarify - such feature may not be useful on the devices with small displays, but could be really great on android tablets. Also, small question - is it fine to reach with similar QoL/usability ideas via github comments, or is there some more suitable place? |
Note that for tablets, you can also enable the
If the comments are within the scope to the PR being merged, then posting on the PR is fine. For bug reports, you should create a new issue through the project issue page. Hope that helps! |
Is there any chance that you Could you sent me the apk with the commuts you made ? |
@Davinci4 these changes are available in the latest 4.4 dev2 builds. You can get access to that build from the play store through https://play.google.com/apps/testing/org.godotengine.editor.v4. In addition the apks for each release can be found in https://github.com/godotengine/godot-builds/releases. And lastly the editor apks for each PR can be found under the |
Adds support for launching the Play window in picture-in-picture (PiP) mode, which provides additional flexibility when developing and running the game at the same time especially for phones with limited screen estate.
Screen_Recording_20240817_081346.mp4
Note:
Screen_Recording_20240817_081736.mp4
Screen_Recording_20240827_061351.mp4