Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forgotten get_space() check in GodotArea3D::remove_soft_body_from_query() #97130

Conversation

Rindbee
Copy link
Contributor

@Rindbee Rindbee commented Sep 18, 2024

My fault, I added a get_space() check for the other GodotArea3D::remove_*_from_query() but forgot about soft_body.

Fix #97116.

…rom_query()`

My fault, I added a `get_space()` check for the other `GodotArea3D::remove_*_from_query()`
but forgot about `soft_body`.
@Rindbee Rindbee requested a review from a team as a code owner September 18, 2024 00:03
@akien-mga akien-mga added this to the 4.4 milestone Sep 18, 2024
@akien-mga akien-mga added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 18, 2024
@akien-mga akien-mga merged commit 3abff94 into godotengine:master Sep 18, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@Rindbee Rindbee deleted the check-space-in-remove_soft_body_from_query branch September 18, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release regression topic:physics topic:3d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: _queue_monitor_update: Parameter "get_space()" is null. when deleting an Area3D affecting a SoftBody3D
2 participants