-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve "No meshes to bake" LightmapGI error dialog in the editor #98297
Improve "No meshes to bake" LightmapGI error dialog in the editor #98297
Conversation
593f6f2
to
89b0c35
Compare
89b0c35
to
995a7c9
Compare
The error dialog now gives advice on the steps to follow to enable lightmapping support on imported scenes and primitive meshes.
995a7c9
to
78fc90e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm now realizing how unfamiliar I really am with TTR
& its expectations. Will translations for these adjusted options be added over time at a later point?
In any case, codestyle checks out 👍
I run these updates roughly once per month (though I'm a month behind now due to being on leave), which basically implies:
|
Thanks for the explanation @akien-mga, I didn't know the whole process! |
This makes me think we should really have dedicated articles inside the editor for these kind of things. Like, this pop up is awfully verbose, but in a built-in documentation article, it would be awesome. |
Thanks! |
We can have the docs link to various manual pages, but I'm not sure if we should duplicate the whole page inside the editor. While this would allow for offline access, it would also increase the workload for translators a lot while also needing to keep both copies in sync. |
The error dialog now gives advice on the steps to follow to enable lightmapping support on imported scenes, primitive meshes and CSG meshes.
The old message referred to a property that was removed in Godot 4.0 (in fact, it may never have existed under the precise name stated in the dialog).
Preview