Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "No meshes to bake" LightmapGI error dialog in the editor #98297

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 18, 2024

The error dialog now gives advice on the steps to follow to enable lightmapping support on imported scenes, primitive meshes and CSG meshes.

The old message referred to a property that was removed in Godot 4.0 (in fact, it may never have existed under the precise name stated in the dialog).

Preview

image

@Calinou Calinou force-pushed the editor-tweak-lightmapgi-no-meshes-to-bake-error-dialog branch from 593f6f2 to 89b0c35 Compare October 18, 2024 20:54
@Calinou Calinou force-pushed the editor-tweak-lightmapgi-no-meshes-to-bake-error-dialog branch from 89b0c35 to 995a7c9 Compare November 1, 2024 01:21
The error dialog now gives advice on the steps to follow to enable
lightmapping support on imported scenes and primitive meshes.
@Calinou Calinou force-pushed the editor-tweak-lightmapgi-no-meshes-to-bake-error-dialog branch from 995a7c9 to 78fc90e Compare November 1, 2024 01:21
Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm now realizing how unfamiliar I really am with TTR & its expectations. Will translations for these adjusted options be added over time at a later point?

In any case, codestyle checks out 👍

@akien-mga
Copy link
Member

I'm now realizing how unfamiliar I really am with TTR & its expectations. Will translations for these adjusted options be added over time at a later point?

TTR strings are extracted manually via a Python script in https://github.com/godotengine/godot-editor-l10n.

I run these updates roughly once per month (though I'm a month behind now due to being on leave), which basically implies:

  • Grabbing new translated strings from Weblate
  • Updating source strings from Godot master
  • Merging both together
  • Committing the updated strings to Godot
  • Pushing the new state to Weblate with new strings to translate

@adamscott
Copy link
Member

adamscott commented Nov 19, 2024

Thanks for the explanation @akien-mga, I didn't know the whole process!

@adamscott
Copy link
Member

This makes me think we should really have dedicated articles inside the editor for these kind of things. Like, this pop up is awfully verbose, but in a built-in documentation article, it would be awesome.

@Repiteo Repiteo merged commit 918faec into godotengine:master Nov 19, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 19, 2024

Thanks!

@Calinou Calinou deleted the editor-tweak-lightmapgi-no-meshes-to-bake-error-dialog branch November 19, 2024 22:08
@Calinou
Copy link
Member Author

Calinou commented Nov 19, 2024

This makes me think we should really have dedicated articles inside the editor for these kind of things. Like, this pop up is awfully verbose, but in a built-in documentation article, it would be awesome.

We can have the docs link to various manual pages, but I'm not sure if we should duplicate the whole page inside the editor. While this would allow for offline access, it would also increase the workload for translators a lot while also needing to keep both copies in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants