This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
refactor: instant-finality feature via special RPC url #568
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPC method updated in this PR:
eth_getTransactionReceipt
eth_getBlockByNumber
eth_getBlockTransactionCountByNumber
eth_getTransactionByBlockNumberAndIndex
which does not support pending in our code since a long time ago, we might need to check those 3 RPC methods later
In this pr, we use different RPC URLs to tell if the instant-finality-hack mode is enabled so that we can provide the feature for user while keeping other users who care more about compatibility than such feature happy as well.
Notice how the integration tests last longer in non-instant-finality mode, this can be reduced after we finished the following todos:
TODO before PR merge:
localhost:8024/instant-finality-hack
modeOne test case is also altered to allow CI to pass under non-instant-finality mode.