Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

[DO NOT MERGE] fix: remove instant-finality hack #334

Closed
wants to merge 1 commit into from

Conversation

RetricSu
Copy link
Contributor

todo: support pending for transactions / logs

@RetricSu RetricSu marked this pull request as draft May 12, 2022 12:25
@RetricSu RetricSu marked this pull request as ready for review May 16, 2022 06:17
@RetricSu RetricSu changed the base branch from compatibility-breaking-changes to main May 16, 2022 06:17
@RetricSu RetricSu changed the base branch from main to compatibility-breaking-changes May 16, 2022 06:17
@RetricSu RetricSu changed the title fix: remove instant-finality hack [DO NOT MERGE] fix: remove instant-finality hack May 17, 2022
@Flouse Flouse marked this pull request as draft May 17, 2022 09:40
@RetricSu
Copy link
Contributor Author

code should be ready. however, after removing the instant-finality feature, we have to tune godwoken block interval to a much short time to enable the same UX for developers. and this depends on godwoken pr to refactor the block producer. we should wait for the upstream updates.

@RetricSu RetricSu changed the base branch from compatibility-breaking-changes to main May 26, 2022 07:51
@RetricSu
Copy link
Contributor Author

RetricSu commented Nov 7, 2022

@RetricSu RetricSu closed this Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants