Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support revert inner state and add syscalls #835

Merged
merged 10 commits into from
Nov 3, 2022
Merged

Support revert inner state and add syscalls #835

merged 10 commits into from
Nov 3, 2022

Conversation

jjyr
Copy link
Collaborator

@jjyr jjyr commented Oct 31, 2022 •
edited
Loading

  • Use layered StateDB to operate the state.
    • Implement in memory journals on StateDB, it support reverts nested state before write to RocksDB.
  • Support revert / create godwoken syscalls.

@jjyr jjyr requested a review from a team October 31, 2022 09:45
@gw-bot

This comment was marked as outdated.

Sign in to view
@jjyr jjyr marked this pull request as ready for review November 1, 2022 10:32
@Flouse Flouse requested a review from zeroqn November 1, 2022 11:40
@Flouse Flouse added the P-High label Nov 1, 2022
@jjyr jjyr requested review from blckngm and a team November 1, 2022 13:49
@Flouse
Copy link
Collaborator

Flouse commented Nov 1, 2022 •
edited
Loading

Please fix cargo clippy check

@jjyr jjyr force-pushed the support-revert-inner-state-and-add-syscalls branch from 8e57571 to a847135 Compare November 1, 2022 14:11
@jjyr jjyr mentioned this pull request Nov 1, 2022
Merged
@godwokenrises godwokenrises deleted a comment from gw-bot bot Nov 1, 2022
@gw-bot

This comment was marked as outdated.

Sign in to view
@godwokenrises godwokenrises deleted a comment from gw-bot bot Nov 2, 2022
@gw-bot

This comment was marked as outdated.

Sign in to view
blckngm
blckngm previously approved these changes Nov 2, 2022
View reviewed changes
@jjyr jjyr requested a review from a team November 2, 2022 10:45
@jjyr jjyr requested a review from blckngm November 2, 2022 10:49
@gw-bot

This comment was marked as outdated.

Sign in to view
zeroqn
zeroqn previously approved these changes Nov 2, 2022
View reviewed changes
blckngm
blckngm previously approved these changes Nov 2, 2022
View reviewed changes
@jjyr jjyr dismissed stale reviews from blckngm and zeroqn via 637105b November 3, 2022 06:27
@jjyr jjyr force-pushed the support-revert-inner-state-and-add-syscalls branch from 6028580 to 637105b Compare November 3, 2022 06:27
@gw-bot

This comment was marked as outdated.

Sign in to view
@jjyr jjyr requested review from blckngm and zeroqn November 3, 2022 06:28
@gw-bot

This comment was marked as outdated.

Sign in to view
@gw-bot
Copy link

gw-bot bot commented Nov 3, 2022 •
edited
Loading

Running integration test

Workflow Run Id: 3383714284

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

@jjyr jjyr requested a review from a team November 3, 2022 07:30
@jjyr jjyr merged commit 4714bdc into godwokenrises:develop Nov 3, 2022
@jjyr jjyr deleted the support-revert-inner-state-and-add-syscalls branch November 3, 2022 08:21
This was referenced Nov 13, 2022
Merged
Merged
@blckngm blckngm mentioned this pull request Nov 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroqn zeroqn zeroqn approved these changes

@blckngm blckngm blckngm approved these changes

Assignees

@jjyr jjyr

Labels
P-High
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjyr @Flouse @blckngm @zeroqn