Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use mem pool state for “get block” RPCs #871

Merged
merged 1 commit into from
Nov 23, 2022
Merged

fix: use mem pool state for “get block” RPCs #871

merged 1 commit into from
Nov 23, 2022

Conversation

blckngm
Copy link
Contributor

@blckngm blckngm commented Nov 23, 2022

PR #742 is unintentionally reverted in #835, causing get script errors for web3-indexer.

@gw-bot
Copy link

gw-bot bot commented Nov 23, 2022 •
edited
Loading

Running integration test

Workflow Run Id: 3530106647

Components:

Manually running integration test

Post a comment contains

/itest
[prebuilds: tag]
[godwoken: branch/ref]
[scripts: branch/ref]
[polyjuice: branch/ref]
[web3: branch/ref]
[kicker: branch/ref]
[tests: branch/ref]

Note: [] means optional, for example

/itest
prebuilds: dev-202203280240
godwoken: develop
scripts: 81676d9d53ffdf5bbaa60483928d07da16eb4a88
polyjuice: e37553b9

Run Result

success

@blckngm blckngm requested review from jjyr and zeroqn November 23, 2022 07:39
@jjyr jjyr merged commit 0e8fa17 into godwokenrises:develop Nov 23, 2022
@jjyr jjyr mentioned this pull request Nov 25, 2022
Merged
@Flouse Flouse mentioned this pull request Nov 29, 2022
Merged
@Flouse Flouse linked an issue Nov 29, 2022 that may be closed by this pull request
[BUG] eth_ Call query prompts' check balance err: ScriptHashNotFound 'error godwokenrises/godwoken-web3#574
Closed
@Flouse Flouse mentioned this pull request Dec 2, 2022
Merged
@blckngm blckngm deleted the fix-get-block-mem-pool-state branch March 14, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroqn zeroqn zeroqn approved these changes

@jjyr jjyr jjyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] eth_ Call query prompts' check balance err: ScriptHashNotFound 'error
3 participants
@blckngm @jjyr @zeroqn