-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release failed flock #43
Conversation
9fa3b6d
to
958d664
Compare
Howdy @theckman sorry to ping you, do you have the time to review ? Should I ping someone else ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution, it looks great! 👍 I do have two small suggestions that I'd love your thoughts on, but beyond those this looks good to go.
Hello there ! So sorry the notification for this completely went past my attention ! I applied your suggestions there 🙂 I agree it's better to say what went wrong |
Hello there sorry to bump you, is there something else I can do to make this PR better ? Thanks ! |
Thanks ! |
Thank you for the contribution!! |
Howdy, this supersedes and closes #31, fixes #30
based on comments of #31.
The only way to test private fields was to create a new testing file.