Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update flock to use the upstream lib + go mod tidy #9805

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Conversation

azr
Copy link
Contributor

@azr azr commented Aug 24, 2020

close #8846

after gofrs/flock#43 was merged

@azr azr added core Core components of Packer tech-debt Issues and pull requests related to addressing technical debt or improving the codebase labels Aug 24, 2020
@azr azr requested a review from a team as a code owner August 24, 2020 08:29
@azr azr mentioned this pull request Aug 24, 2020
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #9805 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted Files Coverage Δ
packer/communicator.go 75.53% <0.00%> (-1.07%) ⬇️

Copy link
Member

@sylviamoss sylviamoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better late than never 🎉 👍

@azr azr merged commit fbfe31c into master Aug 24, 2020
@azr azr deleted the azr-up-flock branch August 24, 2020 08:49
@SwampDragons
Copy link
Contributor

YAY!!!!

@ghost
Copy link

ghost commented Oct 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core Core components of Packer tech-debt Issues and pull requests related to addressing technical debt or improving the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packer 1.5.4 build error
3 participants