-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce configurable concurrency in gc run #18576
Conversation
Signed-off-by: hemanth132 <hemanth.muppuri@razorpay.com>
12f50f9
to
5b8fc02
Compare
Codecov Report
@@ Coverage Diff @@
## main #18576 +/- ##
===========================================
- Coverage 67.38% 44.70% -22.69%
===========================================
Files 984 235 -749
Lines 107010 13089 -93921
Branches 2670 2670
===========================================
- Hits 72108 5851 -66257
+ Misses 31024 6944 -24080
+ Partials 3878 294 -3584
Flags with carried forward coverage won't be shown. Click here to find out more. |
@wy65701436 @zyyw hey folks, waiting for your review. let me know if something is missing. |
@hemanth132 can you add some tests to your code? |
@hemanth132, can you join the Harbor Slack channel to continue our discussion? |
Hi @hemanth132, thank you for your contribution. Regarding the multiple deletion issue, it has already been addressed in #18855. For the multiple deletion feature, I suggest narrowing it down to the sweep phase since it won't take up too much time in the mark phase. However, it needs to handle the API and front-end IO as well. And would you mind to close this pull request? |
This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main. |
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Introduced configurable concurrency within a gc run to speed up the GC
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: