Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multiple deletion of GC #18855

Merged
merged 2 commits into from
Jun 29, 2023
Merged

add multiple deletion of GC #18855

merged 2 commits into from
Jun 29, 2023

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Jun 26, 2023

User can specify the workers when to issue an GC execution, the maxium count of workers is 5.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@wy65701436 wy65701436 requested a review from a team as a code owner June 26, 2023 16:51
@wy65701436 wy65701436 added target/2.9.0 release-note/enhancement Label to mark PR to be added under release notes as enhancement labels Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #18855 (0574a34) into main (02a1c41) will decrease coverage by 0.01%.
The diff coverage is 34.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18855      +/-   ##
==========================================
- Coverage   67.37%   67.37%   -0.01%     
==========================================
  Files         981      981              
  Lines      106925   107000      +75     
  Branches     2678     2678              
==========================================
+ Hits        72046    72090      +44     
- Misses      31002    31034      +32     
+ Partials     3877     3876       -1     
Flag Coverage Δ
unittests 67.37% <34.02%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/server/v2.0/handler/gc.go 2.40% <21.73%> (+2.40%) ⬆️
src/jobservice/job/impl/gc/garbage_collection.go 48.33% <30.37%> (+1.52%) ⬆️
src/controller/gc/controller.go 72.66% <100.00%> (+0.39%) ⬆️
src/jobservice/job/impl/gc/util.go 54.90% <100.00%> (+19.90%) ⬆️

... and 7 files with indirect coverage changes

@wy65701436 wy65701436 force-pushed the gc-multiple branch 10 times, most recently from cd29e8d to 3b5b6ad Compare June 27, 2023 09:02
src/go.mod Outdated Show resolved Hide resolved
User can specify the workers when to issue an GC execution, the maxium count of workers is 5.

Signed-off-by: wang yan <wangyan@vmware.com>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 7435c8c into goharbor:main Jun 29, 2023
10 of 12 checks passed
AllForNothing pushed a commit to AllForNothing/harbor that referenced this pull request Jul 3, 2023
1. Related back-end PR goharbor#18855

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing mentioned this pull request Jul 3, 2023
5 tasks
AllForNothing pushed a commit to AllForNothing/harbor that referenced this pull request Jul 3, 2023
1. Related back-end PR goharbor#18855

Signed-off-by: AllForNothing <sshijun@vmware.com>
AllForNothing added a commit that referenced this pull request Jul 4, 2023
1. Related back-end PR #18855

Signed-off-by: AllForNothing <sshijun@vmware.com>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
User can specify the workers when to issue an GC execution, the maxium count of workers is 5.

Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
User can specify the workers when to issue an GC execution, the maxium count of workers is 5.

Signed-off-by: wang yan <wangyan@vmware.com>
@Vad1mo Vad1mo added the area/gc label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gc release-note/enhancement Label to mark PR to be added under release notes as enhancement target/2.9.0
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

5 participants