Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaceShortcodeTokens should modify the input slice #1516

Closed
bep opened this issue Oct 23, 2015 · 4 comments
Closed

replaceShortcodeTokens should modify the input slice #1516

bep opened this issue Oct 23, 2015 · 4 comments
Assignees
@bep
Labels
Enhancement Outdated

Comments

@bep
Copy link
Member

bep commented Oct 23, 2015

See

https://github.com/spf13/hugo/blob/master/hugolib/shortcode.go#L471

Currently a []byte copy is returned. In most cases this is the safe thing to do, but we should just modify/grow the slice as needed:

  1. Will be faster / less memory use.
  2. It is better that Page.rawContent reflects the content after shortcode expansion.
@bep bep self-assigned this Oct 23, 2015
@arunk-s
Copy link
Contributor

arunk-s commented Oct 29, 2015

I can help on this one, if no one else is already working on this. Will need a little more help though.

@bep
Copy link
Member Author

bep commented Oct 29, 2015

@arunk-s I have started on this task, and plan to finish it when I get some spare time.

@arunk-s
Copy link
Contributor

arunk-s commented Oct 29, 2015

@bep Cool. :)

bep added a commit that referenced this issue Nov 13, 2015
@bep
Get rid of allocation in the BenchmarkReplaceShortcodeTokens itself
53a5932 
So we can see the real numbers.

See #1516
@bep bep mentioned this issue Nov 13, 2015
Closed
bep added a commit to bep/hugo that referenced this issue Nov 17, 2015
@bep
Make replaceShortcodeTokens modify the input slice
5643aa8 
Currently a `[]byte` copy is returned. In most cases this is the safe thing to do, but we should just modify/grow the slice as needed.

This is faster and consumes less memory:

```
benchmark                             old ns/op     new ns/op     delta
BenchmarkReplaceShortcodeTokens-4     7350          4419          -39.88%

benchmark                             old allocs     new allocs     delta
BenchmarkReplaceShortcodeTokens-4     5              1              -80.00%

benchmark                             old bytes     new bytes     delta
BenchmarkReplaceShortcodeTokens-4     4816          1152          -76.08%
```

This commit is aso a small spring cleaning of duplicated code in the different `PageConvert` methods.

Fixes gohugoio#1516
@bep bep closed this as completed in b08d9f2 Nov 17, 2015
bramp pushed a commit to bramp/hugo that referenced this issue Dec 17, 2015
@bep @bramp
Get rid of allocation in the BenchmarkReplaceShortcodeTokens itself
e5bdf41 
So we can see the real numbers.

See gohugoio#1516
bramp pushed a commit to bramp/hugo that referenced this issue Dec 17, 2015
@bep @bramp
Make replaceShortcodeTokens rewrite the input slice
dfe1a3e 
Currently a `[]byte` copy is returned. In most cases this is the safe thing to do, but we should just modify/grow the slice as needed.

This is faster and consumes less memory:

```
benchmark                             old ns/op     new ns/op     delta
BenchmarkReplaceShortcodeTokens-4     7350          4419          -39.88%

benchmark                             old allocs     new allocs     delta
BenchmarkReplaceShortcodeTokens-4     5              1              -80.00%

benchmark                             old bytes     new bytes     delta
BenchmarkReplaceShortcodeTokens-4     4816          1152          -76.08%
```

This commit is aso a small spring cleaning of duplicated code in the different `PageConvert` methods.

Fixes gohugoio#1516
tychoish pushed a commit to tychoish/hugo that referenced this issue Aug 13, 2017
@bep @tychoish
Get rid of allocation in the BenchmarkReplaceShortcodeTokens itself
80d1187 
So we can see the real numbers.

See gohugoio#1516
tychoish pushed a commit to tychoish/hugo that referenced this issue Aug 13, 2017
@bep @tychoish
Make replaceShortcodeTokens rewrite the input slice
161dcd0 
Currently a `[]byte` copy is returned. In most cases this is the safe thing to do, but we should just modify/grow the slice as needed.

This is faster and consumes less memory:

```
benchmark                             old ns/op     new ns/op     delta
BenchmarkReplaceShortcodeTokens-4     7350          4419          -39.88%

benchmark                             old allocs     new allocs     delta
BenchmarkReplaceShortcodeTokens-4     5              1              -80.00%

benchmark                             old bytes     new bytes     delta
BenchmarkReplaceShortcodeTokens-4     4816          1152          -76.08%
```

This commit is aso a small spring cleaning of duplicated code in the different `PageConvert` methods.

Fixes gohugoio#1516
bep added a commit that referenced this issue Oct 31, 2021
@bep
Squashed 'docs/' changes from 327003421..39a7fac34
aa5ac36 
39a7fac34 Add .hugo_build.lock to .gitignore
920c716a4 fix a typo: to -> two (#1545)
6f0ba9593 Remove godocref from front matter (#1543)
8ec3d5948 remove link to wercker (#1544)
b56008719 Delete deployment-with-wercker.md (#1542)
e33d29b02 Fix broken links (#1538)
29e9d4c21 Sort commenting systems (#1541)
0b7ea60a7 Delete the news page "HTTP/2 Server Push in Hugo"
6e1515857 Fix quick-start.md (#1525)
62168ab35 Update comments.md (#1535)
d92191512 Small typo (#1539)
129c8834a Correct the PostCSS noMap default value (#1534)
6a5b29fcc Add example to index function (#1536)
e3dd8c507 Update output-formats.md
0c9321ca0 Remove reference to using LiveReload in production environment
4072d6776 Mod testing
09fabf7d6 Fix typo (#1524)
2fce813c8 Fix grammatical error in quick-start.md (#1523)
45230ab4a Hugo Mod testing
2dd4cd9e7 Update index.md
2c3ed62fd netlify: Bump to 0.88.1
648e2a007 Merge branch 'tempv0.88.1'
f216eade1 releaser: Add release notes to /docs for release of 0.88.1
8a7b64d4b Fix typographical errors in 0.88.0 release notes
a4bf86300 Release 0.88
738bb8f38 releaser: Add release notes to /docs for release of 0.88.0
8fcf2c55d highlight: Remove some pygments references
f2b173de2 HTTPS link
c88881c8e Adding link to nginx documentation
6b0a74fe0 Fix typos in docs (#1516)
498b8f0f1 Fix typos in time.Format (#1515)
28723fad6 Fix taxonomy and term examples (#1514)
3ffd00e12 Update front-matter.md
7cc1da82e Fix grammar in 0.86.1 release notes (#1510)
0009c51c3 Update docs helper
7e2f430f4 Update index.md
7857eae7e releaser: Add release notes to /docs for release of 0.87.0
1f08b684b releaser: Add release notes to /docs for release of 0.87.0
36a9e701c docs: Adjust config docs
0f588438e docs: Regen CLI docs
1b4682cd8 docs: Regen docs helper
bc8bbaae9 Merge commit 'bd77f6e1c99e04a476f0b1bb4e44569134e02399' into release-0.87.0
6f2480643 docs: Adjust time zone docs

git-subtree-dir: docs
git-subtree-split: 39a7fac343c289906db644c96079fdcc0298582f
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Enhancement Outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make replaceShortcodeTokens modify the input slice bep/hugo
2 participants
@bep @arunk-s