Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs site renders incorrectly in Firefox #1523

Closed
callahad opened this issue Oct 26, 2015 · 5 comments
Closed

Docs site renders incorrectly in Firefox #1523

callahad opened this issue Oct 26, 2015 · 5 comments
Labels
Docs Outdated

Comments

@callahad
Copy link
Contributor

Notice the arrows in this screenshot:

screen shot 2015-10-26 at 12 32 53

This is due to the order the arrows appear in the DOM, along with their being floated right. Switching to flexbox would make this work pretty trivially.
@ffrizzo ffrizzo mentioned this issue Oct 28, 2015
Closed
anthonyfok pushed a commit that referenced this issue Oct 31, 2015
@ffrizzo @anthonyfok
Fix doc render on Firefox
f022ecd 
Fix #1523
@anthonyfok
Copy link
Member

Hi @callahad,

@ffrizzo's solution does fix the rendering issue on Firefox (as well as Iceweasel and Icecat) quite nicely without converting the site layout to flexbox. However, if you think it would be best if we switch the documentation menu layout to flexbox in the future, please feel free to file a new issue for it. :-)

Cheers,
Anthony

@anthonyfok
Copy link
Member

Oh, I forgot to add: gohugo.io uses CloudFlare, which caches static assets like CSS and image files like docs/static/css/style.css that @ffrizzo modified. It takes some time for the cache to clear and refreshed, so you won't see the fixed rendering right away. But it will happen. :-)

Cc: @spf13

@callahad
Copy link
Contributor Author

Thanks!

The code in 217ffa8 is a browser-specific hack which increases the project's complexity and likelihood of breaking in the future.

Can we revert and look for a cross-browser solution so we don't add technical debt?

@callahad
Copy link
Contributor Author

(FWIW, I'm fine with or without flexbox, only suggesting it since other parts of the docs already use display: flex)

bramp pushed a commit to bramp/hugo that referenced this issue Dec 17, 2015
@ffrizzo @bramp
Fix doc render on Firefox
d3c05e7 
Fix gohugoio#1523
@robertbasic robertbasic mentioned this issue Mar 30, 2016
Closed
@MarkDBlackwell MarkDBlackwell mentioned this issue Jan 4, 2017
Closed
tychoish pushed a commit to tychoish/hugo that referenced this issue Aug 13, 2017
@ffrizzo @tychoish
Fix doc render on Firefox
9818934 
Fix gohugoio#1523
bep added a commit that referenced this issue Oct 31, 2021
@bep
Squashed 'docs/' changes from 327003421..39a7fac34
aa5ac36 
39a7fac34 Add .hugo_build.lock to .gitignore
920c716a4 fix a typo: to -> two (#1545)
6f0ba9593 Remove godocref from front matter (#1543)
8ec3d5948 remove link to wercker (#1544)
b56008719 Delete deployment-with-wercker.md (#1542)
e33d29b02 Fix broken links (#1538)
29e9d4c21 Sort commenting systems (#1541)
0b7ea60a7 Delete the news page "HTTP/2 Server Push in Hugo"
6e1515857 Fix quick-start.md (#1525)
62168ab35 Update comments.md (#1535)
d92191512 Small typo (#1539)
129c8834a Correct the PostCSS noMap default value (#1534)
6a5b29fcc Add example to index function (#1536)
e3dd8c507 Update output-formats.md
0c9321ca0 Remove reference to using LiveReload in production environment
4072d6776 Mod testing
09fabf7d6 Fix typo (#1524)
2fce813c8 Fix grammatical error in quick-start.md (#1523)
45230ab4a Hugo Mod testing
2dd4cd9e7 Update index.md
2c3ed62fd netlify: Bump to 0.88.1
648e2a007 Merge branch 'tempv0.88.1'
f216eade1 releaser: Add release notes to /docs for release of 0.88.1
8a7b64d4b Fix typographical errors in 0.88.0 release notes
a4bf86300 Release 0.88
738bb8f38 releaser: Add release notes to /docs for release of 0.88.0
8fcf2c55d highlight: Remove some pygments references
f2b173de2 HTTPS link
c88881c8e Adding link to nginx documentation
6b0a74fe0 Fix typos in docs (#1516)
498b8f0f1 Fix typos in time.Format (#1515)
28723fad6 Fix taxonomy and term examples (#1514)
3ffd00e12 Update front-matter.md
7cc1da82e Fix grammar in 0.86.1 release notes (#1510)
0009c51c3 Update docs helper
7e2f430f4 Update index.md
7857eae7e releaser: Add release notes to /docs for release of 0.87.0
1f08b684b releaser: Add release notes to /docs for release of 0.87.0
36a9e701c docs: Adjust config docs
0f588438e docs: Regen CLI docs
1b4682cd8 docs: Regen docs helper
bc8bbaae9 Merge commit 'bd77f6e1c99e04a476f0b1bb4e44569134e02399' into release-0.87.0
6f2480643 docs: Adjust time zone docs

git-subtree-dir: docs
git-subtree-split: 39a7fac343c289906db644c96079fdcc0298582f
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Docs Outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@callahad @anthonyfok