Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid html generated #9159

Closed
tdelmas opened this issue Nov 11, 2021 · 5 comments · Fixed by #9168
Closed

Invalid html generated #9159

tdelmas opened this issue Nov 11, 2021 · 5 comments · Fixed by #9168

Comments

@tdelmas
Copy link

tdelmas commented Nov 11, 2021

What version of Hugo are you using (hugo version)?

$ hugo version
hugo v0.89.2-63E3A5EB+extended linux/amd64 BuildDate=2021-11-08T15:22:24Z VendorInfo=gohugoio 

Does this issue reproduce with the latest release?

Yes.

That issue was not present in Hugo 0.88.1 and is present at least since 0.89.1

Minimal template to reproduce the issue:

---
slug: bug
---

test <a
href="https://exemple.com/">link</a> end.

Important: new lines of that example are CRLF (\r\n), NOT \n. There is no issue when the newlines are \n.

Html generated

<p>test &lt;a
href=&ldquo;<a href="https://exemple.com/%22%3elink">https://exemple.com/">link</a></a> end.</p>

Html expected (and generated by Hugo 0.88.1)

<p>test <a
href="https://exemple.com/">link</a> end.</p>

I tried to reproduce that issue with The goldmark version of Hugo 0.89.2 but without success.

@bep
Copy link
Member

bep commented Nov 11, 2021

I tried to reproduce that issue with The goldmark version of Hugo 0.89.2 but without success.

Are you saying it's fixed in 0.89.2?

@tdelmas
Copy link
Author

tdelmas commented Nov 11, 2021

Are you saying it's fixed in 0.89.2?

No, The issue is present in Hugo 0.89.1 and 0.89.2.

But, I didn't succeed to reproduce it in goldmark. I don't know if:

  • I just made a mistake when testing with goldmark (I'm not fluent in go)
  • Or the bug is not in goldmark but in the way Hugo transmits the file content to goldmark

@bep bep added this to the v0.89.3 milestone Nov 11, 2021
@jmooring
Copy link
Member

yuin/goldmark#263

@tdelmas
Copy link
Author

tdelmas commented Nov 14, 2021

I think it should be fixed with Goldmark 1.4.4

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants