Add force flag to init new site inside non empty dir #1459
Conversation
|
What do you mean by "x,y,z"? Also, could you get your commit message in line with the guidelines? |
| jww.FATAL.Fatalln(createpath, "already exists and is not empty") | ||
| } | ||
|
|
||
| if forceNew { | ||
| if err = os.RemoveAll(createpath); err != nil { |
There was a problem hiding this comment.
Remove all? That's a gotcha for most users using this flag.
There was a problem hiding this comment.
Only if you pass force flag. Can make a backup
There was a problem hiding this comment.
The flag help text says "create even if destination is not empty"". It says nothing about deleting stuff. And rightfully so.
There was a problem hiding this comment.
I edited flag help text & commit message.
The variables inside the method were called "x", "y" and "z".
I renamed them to increase readability.
Should it make a backup before removing?
ns3777k
changed the title
|
Hi @ns3777k, I think even with the Otherwise, this |
|
Agree with @anthonyfok No deletions. Not even after prompting the user. I do not want to be responsible for wiping out peoples stuff. |
|
Misunderstood the issue. Got you. Get done on Sunday. |
|
Edited so there's no prompt or deletion. |
|
@ns3777k Thanks for this. The users will really benefit from it. It would be great to have a test accompanying it since it has gotten a bit complex. |
If flag is passed the site will be created inside non-empty folder only if there are no existent folders or config with the same name hugo creates. Resolves: #1163
|
@spf13 Done. |
|
@ns3777k Please click on the "Details" link to the right of the license/cla line and click "approve" so we can merge this. The CLA isn't new, but this integration is. Thanks! |
|
@spf13 Approved. |
|
Merged in 5e97cf3 |
316cec249 Update future events template example (#1595) 3bde7d489 Install mage outside module (#1592) 762e27eff Clarify ignoreFiles regex matching 4d0032051 Add id attribute to h2 elements (#1590) 8262b077c Improve inline resource examples (#1587) 2eae7c7ec fix disqus example name (#1588) a772f4804 Added install instructions for openSUSE Tumbleweed (#1459) 7ad1c301b Remove screen capture from Hosting on GitHub page (#1586) a58541f49 add more details on about gh-pages and baseURL on hosting-on-github.md (#1346) 3bd0b46dc Update configuration page (#1585) 4cf1f013e Update OS functions 2c45a95c2 Remove getting-started/code-toggle/ 40fdff598 Describe artificial language private use subtags (#1577) 91011d210 Remove google_news from list of internal templates (#1576) 36c7879e4 Update the .Unix function 731063488 Remove a showcase 818c371a0 Update index.md 3136d39d9 netlify: Hugo 0.89.4 092bc9278 Merge branch 'tempv0.89.4' 18e01f105 releaser: Add release notes to /docs for release of 0.89.4 79135281f Correct and sort list of target image formats (#1574) af4170c7e netlify: Hugo 0.89.3 7f5444251 Merge branch 'tempv0.89.3' a32e4a6c2 releaser: Add release notes to /docs for release of 0.89.3 6dd3dc3f9 Update configuration.md 5fbe741d7 Update index.md (#1570) 37a69496f netlify: Bump to Hugo 0.89.2 3b293f1f4 Merge branch 'tempv0.89.2' 64c934e7a releaser: Add release notes to /docs for release of 0.89.2 919c51c7d Update index.md 13dd463b1 netlify: Hugo 0.89.1 d8cda1474 releaser: Add release notes to /docs for release of 0.89.1 a2adf7742 releaser: Add release notes to /docs for release of 0.89.1 c3088c4fc Add code toggle to menus page (#1568) 2d0f38978 Remove blank lines from code-toggle output (#1564) 7cf058bfd Add localization examples (#1563) cf8627c2e Fixing typos, fixing incomplete link (#1561) c78cc014b Document the removePathAccents setting 70beddaf4 Make corrections to 0.89.0 release notes (#1560) 1917195f0 Update index.md 7fb8e070c Run hugo --gc 1772d45fb Release 0.89.0 d9006179b Merge branch 'tempv0.89.0' 8db86b61e releaser: Add release notes to /docs for release of 0.89.0 abf268571 docs: Regen CLI docs fbbdb0ab1 Update the timeout default 9cbd1c15a Fix description of lang.FormatNumberCustom 6043b54cc Remove "render" keyword from Host on Render page f8ea8e84f Clarify description of front matter url (#1557) 91a0c9954 Update Twitter shortcode oEmbed endpoint 79a7405b8 Merge commit 'aa5ac36a3eb68b86c803caec703869efefc8447e' 57667bae6 hugofs: Add includeFiles and excludeFiles to mount configuration 0c9ee0a04 Allow multiple plugins in the PostCSS options map 155799e6b docs: Create path.Clean documentation git-subtree-dir: docs git-subtree-split: 316cec2494dc5f908283289371d74f36a73d3d8d
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Add force flag
If flag is passed the site will be created inside non-empty folder
only if there are no existent folders or config with the same name
hugo creates.
Resolves: #1163