Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docker-build): optimize the docker build process #4157

Closed
wants to merge 4 commits into from

Conversation

ellerbrock
Copy link
Contributor

hello @tjamet,

like discussed in #4154 i updated the dockerfile for faster build times.

it's always a pleasure to work together with other smart people on open source project and end up with something better then before.

smart

cheers maik

Signed-off-by: Maik Ellerbrock <opensource@frapsoft.com>
@ellerbrock
Copy link
Contributor Author

i added a .dockerignore file like mentioned in docker best practices and excluded some folders to optimize the build time a bit.

@stale
Copy link

stale bot commented Mar 11, 2018

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Hugo team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@stale stale bot added the Stale label Mar 11, 2018
@bep bep added the Keep label Mar 11, 2018
@stale stale bot removed the Stale label Mar 11, 2018
anthonyfok pushed a commit that referenced this pull request Jun 14, 2018
- Hugo container is based on SCRATCH to further reduce the footprint
  and the vulnerability surface
- Update Alpine image to 3.7 in the build container
- Update Go Lang to 1.10 in the build container
- Add .dockerignore file per the Docker best practices

Closes #4154, #4155, #4157
@anthonyfok
Copy link
Member

This pull request from December 2017 was superseded by PR #4518 in March 2018. Many thanks to @ellerbrock and @skoblenick for your group effort in improving Dockerfile!

@anthonyfok anthonyfok closed this Jun 15, 2018
@anthonyfok anthonyfok removed the Keep label Jun 15, 2018
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants