Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile to a multi-stage build #4518

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Update Dockerfile to a multi-stage build #4518

merged 1 commit into from
Jun 14, 2018

Conversation

skoblenick
Copy link
Contributor

These changes are the sum of the work done by @ellerbrock in
previous pull requests. As those branches are stale and have
conflicts this should bring the work up-to-date.

  • Hugo container is based on SCRATCH to further reduce the
    footprint and the vulnerability surface
  • Update Alpine image to 3.7 in the build container
  • Update Go Lang to 1.10 in the build container
  • Add .dockerignore file per the Docker best practices

Closes #4154, #4155, #4157

bep
bep reviewed Mar 18, 2018
View reviewed changes
Dockerfile Outdated
FROM golang:1.9.0-alpine3.6 AS build
# GitHub: https://github.com/gohugoio/
# DockerHub: https://hub.docker.com/r/gohugoio/
# Quay: https://quay.io/user/gohugoio
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some accounts above that I don't recognize. I think it is better to just leave the official 2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @bep,

like mentioned a while ago here i created those accounts to be consistent with the naming. just let me know when you consider to use them and i will hand them over to you ...

cheers maik

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bep Updated to only official

@skoblenick
Update Dockerfile to a multi-stage build
472db84 
- Hugo container is based on SCRATCH to further reduce the footprint
  and the vulnerability surface
- Update Alpine image to 3.7 in the build container
- Update Go Lang to 1.10 in the build container
- Add .dockerignore file per the Docker best practices

Closes #4154, #4155, #4157
@anthonyfok anthonyfok added this to the v0.43 milestone Jun 14, 2018
@anthonyfok anthonyfok merged commit 8531ec7 into gohugoio:master Jun 14, 2018
@anthonyfok anthonyfok mentioned this pull request Jun 15, 2018
Closed
@kav kav mentioned this pull request Aug 10, 2018
Closed
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bep bep bep left review comments

@ellerbrock ellerbrock ellerbrock left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.43
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skoblenick @bep @ellerbrock @anthonyfok