Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theme hugo-theme-gallery #435

Closed
wants to merge 2 commits into from

Conversation

nicokaiser
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for hugothemes ready!

Name Link
🔨 Latest commit e6e5073
🔍 Latest deploy log https://app.netlify.com/sites/hugothemes/deploys/65fd60422fd03a0008028f37
😎 Deploy Preview https://deploy-preview-435--hugothemes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hugo-sid
Copy link
Member

hugo-sid commented Mar 22, 2024

@nicokaiser could you please:

  • rebase your branch against main branch
  • do a force push (to trigger the deploy preview), more info available here

@nicokaiser
Copy link
Contributor Author

The Download link seems to be wrong. I'll try to remove the version from the URL.

@hugo-sid
Copy link
Member

hugo-sid commented Mar 22, 2024

The Download link seems to be wrong.

You are right. The download button on this page leads to a 404. Related: #428.

I'll try to remove the version from the URL.

Then there are no changes in this PR, I guess.

@hugo-sid
Copy link
Member

hugo-sid commented Mar 22, 2024

@nicokaiser, I guess your motivation behind this PR was to update the theme metadata shown on themes website (https://themes.gohugo.io/).

A scheduled GitHub action responsible for updating theme metadata was failing from past few days. This caused the theme information/metadata displayed on themes website to be outdated.

I have fixed the GitHub action a few minutes ago. The themes website is now updated with the latest metadata.

Feel free to close this PR if that solved your issue.

@nicokaiser
Copy link
Contributor Author

@hugo-sid Yes, exactly! Maybe it was a combination of "I did not propery update my theme.toml" and the failing GitHub action, so I though I'd need to add the version to the theme URL.

As of now, the website shows a very old version of the theme's README:
https://themes.gohugo.io/themes/hugo-theme-gallery/
vs.
https://github.com/nicokaiser/hugo-theme-gallery/

The website states "Updated: 2023-11-22", so seems to ignore newer versions (current version is 4.x), that's why I thought I need to use the Hugo Module syntax for the theme URL...

@nicokaiser
Copy link
Contributor Author

@hugo-sid The cmd/hugothemesitebuilder/build/go.mod file seems to be outdated for the github.com/nicokaiser/hugo-theme-gallery module. Instead of v0.0.0-* it should use v4.x. How can I update the theme version?

@hugo-sid
Copy link
Member

hugo-sid commented Mar 27, 2024

@nicokaiser, I am trying to address the issue that you have mentioned.

Related PRs: #439, #440

@hugo-sid
Copy link
Member

hugo-sid commented Apr 26, 2024

@nicokaiser, I have created a new PR #440, which updates your theme.

Please check the Netlify deploy preview link there.

Feel free to let me know if there are any issues.

Closing this one for now.

@hugo-sid hugo-sid closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants