Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back the zen theme. #453

Closed
wants to merge 0 commits into from
Closed

Add back the zen theme. #453

wants to merge 0 commits into from

Conversation

frjo
Copy link
Contributor

@frjo frjo commented Apr 24, 2024

Attempting to add back the Zen theme. Related PRs: #439, #440, #435

Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for hugothemes ready!

Name Link
🔨 Latest commit ae0e5da
🔍 Latest deploy log https://app.netlify.com/sites/hugothemes/deploys/662b555cd172e500089e90cb
😎 Deploy Preview https://deploy-preview-453--hugothemes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@frjo
Copy link
Contributor Author

frjo commented Apr 24, 2024

If I add my theme with github.com/frjo/hugo-theme-zen (no version part) the preview does not include the Zen theme at all.

If I add my theme with github.com/frjo/hugo-theme-zen/v3 (with version part) the preview displays the Zen theme in order but with an incorrect path for the download button. It sets the download path to include the version part making the download link end in a 404.

There seems to be a bug with setting html_url for themes with a version. I suspect it works for some theme due to the correct html_url being cached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant