Add auth middleware/tripperware #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Mar 5, 2020
rmasclef
reviewed
Mar 5, 2020
| } | ||
|
|
||
| func DefaultErrorHandler(err error, writer http.ResponseWriter, _ *http.Request) bool { | ||
| http.Error(writer, err.Error(), http.StatusUnauthorized) |
There was a problem hiding this comment.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Authentication
An HTTP response having a 401 statusCode should also return a WWW-Authenticate HTTP header containing the available authorization methods for the requested resource 👍
There was a problem hiding this comment.
We ignore the type of authentication method was try so we cannot return the appropriate WWW-Authenticate value
It's currently a developer side override
|
Code Climate has analyzed commit 8c6a887 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.