Fix case of nil/http.NoBody request.Body on interceptor tripperware/middleware #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit ea5a4ae and detected 0 issues on this pull request. View more on Code Climate. |
|
Looks good to me, thank you |
rmasclef
reviewed
Jan 18, 2024
| @@ -42,7 +43,12 @@ type copyReadCloser struct { | |||
| // Second read after EOF | |||
| // copyBuffered --> copy BufReader simple buffer with fix size | |||
| // when BufReader is EOF offset is reset to read again | |||
| func NewCopyReadCloser(src io.ReadCloser) *copyReadCloser { | |||
| func NewCopyReadCloser(src io.ReadCloser) io.ReadCloser { | |||
There was a problem hiding this comment.
For the reviewers :
- We now return an
io.ReadCloserinterface instead of a concretecopyReadCloser. - When the request body is nil, the Interceptor middleware/tripperware segfaults as it tries to read a nil body without checking it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.