Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

fix(status): print verbose messages #1009

Merged
merged 1 commit into from
Aug 16, 2017

Conversation

darkowlzz
Copy link
Collaborator

@darkowlzz darkowlzz commented Aug 14, 2017

What does this do / why do we need it?

Adds verbose messages to status. This is required to provide some feedback when the operation takes too long.

$ dep status -v
Checking upstream projects:
github.com/Masterminds/semver
github.com/Masterminds/vcs
github.com/armon/go-radix
github.com/go-yaml/yaml
github.com/nightlyone/lockfile
github.com/pelletier/go-buffruneio
github.com/pelletier/go-toml
github.com/pkg/errors
github.com/sdboyer/constext
...

What should your reviewer look out for in this PR?

Verbose message. Maybe better wording?

Do you need help or clarification on anything?

Anything else that we can log here?

Which issue(s) does this PR fix?

Related to #1008

logger := ctx.Err
if !ctx.Verbose {
logger = log.New(ioutil.Discard, "", 0)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this either be combined with the preceding if ctx.Verbose block into an if/else, or can it be moved down closer to it's usage or in a narrower scope?

Copy link
Collaborator Author

@darkowlzz darkowlzz Aug 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! yeah, this can be in else part of the preceding Verbose reference. Thanks :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants