Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

init: more verbose logging #1038

Merged
merged 1 commit into from
Aug 19, 2017
Merged

init: more verbose logging #1038

merged 1 commit into from
Aug 19, 2017

Conversation

jmank88
Copy link
Collaborator

@jmank88 jmank88 commented Aug 19, 2017

What does this do / why do we need it?

This proposes some additional verbose logging for init. It fills in some of the downtime before the solver starts logging.

Example output (with fancy diff highlighting I just discovered):

dep init -v
+ Getting direct dependencies...
+ Checked 4407 directories for packages.
+ Found 39 direct dependencies.
Root project is "github.com/treeder/functions"
...

What should your reviewer look out for in this PR?

Better log message/format ideas. Should we consider logging incrementally while scanning the directories as well?

Which issue(s) does this PR fix?

I didn't see an issue for init -v, but #1008 covering status -v is related

@carolynvs
Copy link
Collaborator

I think the formatting looks just fine! 👍

If we logged per directory, the verbose output would quickly become too much for any reasonably sized project. Either way I'm really not sure that seeing which directory is being processed for imports would assist troubleshooting. If what we really want is a progress bar or some indicating that dep is "working", let's focus on that instead.

@carolynvs carolynvs merged commit 1bef80e into golang:master Aug 19, 2017
@jmank88 jmank88 deleted the init_verbose branch August 19, 2017 14:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants