This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Add gps to github.com/golang/dep/gps #410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are intermittent failures of TestMonitoredCmd that appear to be caused by Appveyor starting created subprocesses too slowly. This change increases that time window from 200ms to 500ms in the hopes that the failures will go away, or at least become less frequent.
This more accurately reflects how we were actually using the method for some time, as well as what we'd more recently modified the method to do.
[WIP] Refactor sourceMgr
Some tests in vcs_source_test did not always delete the temp dir they created. The git-source tests for example only removed the temp dirs for certain failure conditions, but not when the test passed. This is fixed by deferring the cleanup function right after creating the temp dirs for each test.
When running tests, calling t.Errorf followed by a t.FailNow is pretty much the same as just calling t.Fatalf. I've also change a couple of cute error messages.
A bit of cleaning up the tests
This makes the method sets redundant, but sourceBridge shouldn't have a Release() method because it only ever deals with a single solve run. We could have a private unexported interface covering the intersection of the method sets, but then we'd lose out on godoc. Repeating the methods is the least-bad of our options.
On Windows, we're unable to distinguish between symlinks and junctions. Deleting junctions is dangerous and appears to be able to delete the underlying folder, not just the junction that's pointing to a folder. That's unacceptably dangerous: a malicious repo could contain a junction named 'vendor' pointing at 'C:\\' and we'd delete all the user's data.
Add Release() to the SourceManager interface
It's too hard to create junctions with permissions that let filepath.Walk process them.
Fix empty out data check
Follow symlinks when stripping vendor directories
Address issue golang#151
github.com/pelletier/go-toml@fee7787d3f811af92276f5ff10107092e95b7a1d - Can't use latest release, it has a show-stopping bug in ToTomlString github.com/pelletier/go-buffruneio@v0.2.0
Validate that packages imported in an ignored package are not included in the manifest or lock.
krisnova
added a commit
to krisnova/dep
that referenced
this pull request
Apr 21, 2017
Revert a handful of substitutions Remove gps/CONTRIBUTING.md (Can port/replace later) Remove gps/README.md (Can port/replace later) Original code review: golang#410 (review)
ibrasho
pushed a commit
to ibrasho-forks/dep
that referenced
this pull request
May 10, 2017
Revert a handful of substitutions Remove gps/CONTRIBUTING.md (Can port/replace later) Remove gps/README.md (Can port/replace later) Original code review: golang#410 (review)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPRECATED PULL REQUEST
New PR: #453