This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Adding gps to dep #453
Merged
Adding gps to dep #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore dirs/files with perms issues in ListPackages
Introduce monitoredCmd to wrap commands and be able to kill them if no activity is detected in a certain amount of time.
…rocesses Introduce monitoredCmd
1. Remove pipe 2. Indent inner messages over 2 spaces 3. s/3spaces/tab in getprei
Removing nested trace output from trace.go
Not covering this basic aspect of how real project roots actually work allowed a windows bug to hide until real data came through - sdboyer/gps#146.
This was never used, because it wasn't actually needed.
|
I think we should be ready to proceed here now. |
Helps with golang#170
DEPTESTBYPASS501 is now respected to bypass the tests that are failing
Updating .travis.yml to set new bypass flag
sdboyer
reviewed
May 3, 2017
| @@ -16,7 +20,8 @@ func TestSlowVcs(t *testing.T) { | |||
| t.Run("source-gateway", testSourceGateway) | |||
| t.Run("bzr-repo", testBzrRepo) | |||
| t.Run("bzr-source", testBzrSourceInteractions) | |||
| t.Run("svn-repo", testSvnRepo) | |||
| // TODO(kris-nova) re-enable syn-repo after gps is merged into dep | |||
There was a problem hiding this comment.
Why disable this one?
I'm not gonna hold up the PR for it, but noting it so we can make an issue 😄
There was a problem hiding this comment.
Oh it was failing - let me open an issue with more info and I can get it cleaned up!
|
WOOOOOOOOOOOOOO 🎉 🎉 🎉 🎉 |
ibrasho
pushed a commit
to ibrasho-forks/dep
that referenced
this pull request
May 10, 2017
Adding gps to dep
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving a copy of gps at sdboyer/gps@da7569e to
github.com/golang/dep/gpsGit history preservation
All git history from gps at sdboyer/gps@da7569e should be preserved.
With the exception of the following
sedreplacement in thegitcommit logs:Global Substitution
depis now compiling with thegpsno longer in vendorRemove
vendor/github.com/sdboyer/gpsChanges from code review here