x/tools/gopls: support all features on the command line #32875

stamblerre · 2019-07-01T18:23:06Z

gopls features like find references, rename, etc. should work on the command line. Support for them should be added to internal/lsp/cmd. Right now, only definition and format are supported.

The text was updated successfully, but these errors were encountered:

hartzell · 2019-09-06T17:29:38Z

If no one's working on it, I'll take a swing at adding rename. Looks like it's a matter of adding an internal/lsp/cmd/rename.go that defines a type rename struct {...} and fleshing out a Run method for it. Looks like the rename machinery wants to work from a position, seems like I can mimic/steal what the query definition subcommand uses. Anything I'm missing?

hartzell · 2019-09-20T23:42:58Z

I'll take a swing at adding rename

This has been merged, see golang/tools#157. Great support for a first time contributor.

rentziass · 2019-10-16T14:49:23Z

If no one's on it, I'd give references a spin 😊

stamblerre · 2019-10-16T16:10:18Z

@rentziass: Absolutely, please do! Feel free to reach out with any questions here or on the Gophers Slack (https://invite.slack.golangbridge.org/).

kalmanb · 2019-10-17T18:28:29Z

@stamblerre any others need implementation?

stamblerre · 2019-10-17T20:48:25Z

Anything that doesn't have a test in this file is available: https://github.com/golang/tools/blob/e4d7c6f25b8e08c4784d6585835a053ae0ad53bb/internal/lsp/cmd/test/cmdtest.go#L41. I would suggest Import or SuggestedFix as a useful next feature.

kalmanb · 2019-10-18T09:01:12Z

Great, thanks I'll SuggestedFix a go.

gopherbot · 2019-10-19T21:34:59Z

Change https://golang.org/cl/202178 mentions this issue: tools/gopls: add cmd support for references

gopherbot · 2019-10-21T18:57:52Z

Change https://golang.org/cl/202480 mentions this issue: tools/gopls: add command line support for suggestedfix

kalmanb · 2019-10-22T18:27:46Z

I'll also take a look at Import and Link

This adds support for calling import from the gopls command line, e.g. $ gopls imports -w ~/tmp/foo/main.go Optional arguments are: -w, which writes the changes back to the original file; and -d, which prints a unified diff to stdout With no arguments, the changed files are printed to stdout. Updates golang/go#32875

gopherbot · 2019-10-22T21:53:43Z

Change https://golang.org/cl/202624 mentions this issue: tools/gopls: add command line support for imports

rentziass · 2019-10-23T07:27:07Z

I'll keep going with SignatureHelp and Symbol then :)

e.g. $ gopls links ~/tmp/foo/main.go Optional arguments are: -json, which emits range and uri in JSON With no arguments, a unique list of links are emitted. Updates golang/go#32875

gopherbot · 2019-10-24T21:01:24Z

Change https://golang.org/cl/203297 mentions this issue: tools/gopls: add command line support for imports

This change adds command line support for references. Example: $ gopls references ~/tmp/foo/main.go:8:6 $ gopls references ~/tmp/foo/main.go:#53 Updates golang/go#32875 Change-Id: I9a0cf6ae8ba0a5c3d4ffc829b96fe3b42297c192 Reviewed-on: https://go-review.googlesource.com/c/tools/+/202178 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>

gopherbot · 2019-10-27T17:49:43Z

Change https://golang.org/cl/203609 mentions this issue: tools/gopls: add cmd support for symbols

gopherbot · 2019-10-29T13:48:43Z

Change https://golang.org/cl/204057 mentions this issue: tools/gopls: add cmd support for signature

jbszczepaniak · 2019-11-22T16:14:06Z

O, I see, right. It seems that these are yet to be done:

Completion
CompletionSnippet
UnimportedCompletion
DeepCompletion
FuzzyCompletion
CaseSensitiveCompletion
RankCompletion

I will take from the list - Completion

rentziass · 2019-11-22T16:15:12Z

@jbszczepaniak I'm currently working on Completion, see a couple of comments above :)

jbszczepaniak · 2019-11-22T16:30:19Z

🤦‍♂ ok. I believe this is a list (right?):

~~CompletionSnippet~~
UnimportedCompletion
DeepCompletion
FuzzyCompletion
CaseSensitiveCompletion
RankCompletion

Thus I will take CompletionSnippet

stamblerre · 2019-11-22T16:31:56Z

@rentziass: Do you intend to add all of the completion related test code in your CL? In that case, I believe that this issue could be considered done.

rentziass · 2019-11-22T16:33:24Z

I'd surely like to try :)

jbszczepaniak · 2019-11-22T16:37:43Z

O, In that case I will move to something else.

…

On 22 Nov 2019, at 17:33, Francesco Renzi ***@***.***> wrote: I'd surely like to try :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#32875?email_source=notifications&email_token=ADREANDBLCOVT5MRW6ICHRTQVACVTA5CNFSM4H4U2ROKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE6FFUI#issuecomment-557601489>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADREANAYSF55LGFBQH2EESDQVACVTANCNFSM4H4U2ROA>.

Updates golang/go#32875

This change adds command line support for implementation. Example: $ gopls implementation ~/tmp/foo/main.go:8:6 $ gopls implementation ~/tmp/foo/main.go:#53 Updates golang/go#32875 Change-Id: I3aa89a788ded886368b07c1824325069f3cba88a Reviewed-on: https://go-review.googlesource.com/c/tools/+/208357 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>

This change adds command line support for highlight. Provided with an identifier position, it will display the list of highlights for that within the same file. Example: $ gopls highlight ~/tmp/foo/main.go:3:9 $ $ 3:9-6:0 $ 10:22-11:32 $ 12:10-12:9 $ 12:20-30:0 Updates golang/go#32875 Change-Id: I5de73d9fbd9bcc59a3f62e7e9a1331bc3866bc75 Reviewed-on: https://go-review.googlesource.com/c/tools/+/207291 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>

Updates golang/go#32875

This change adds command line support for prepare_rename. Updates golang/go#32875 Change-Id: I7f155b9c8329c0faa26a320abab162730a7916ad GitHub-Last-Rev: 118e846 GitHub-Pull-Request: #188 Reviewed-on: https://go-review.googlesource.com/c/tools/+/207579 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>

daisuzu · 2020-03-14T10:47:09Z

I'll do workspace/symbol.

This change adds command line support for workspace/symbol. Symbols are formatted as '{span} {name} {type}'. $ gopls workspace_symbol -matcher fuzzy 'wsymbols' $ $ workspacesymbol/a/a.go:5:7-31 WorkspaceSymbolConstantA Constant $ workspacesymbol/b/b.go:5:6-28 WorkspaceSymbolStructB Struct Optional arguments are: -matcher, which specifies the type of matcher: fuzzy, caseSensitive, or caseInsensitive. The default is caseInsensitive. Updates golang/go#32875 Change-Id: Ieef443b13710f9c973210e58f66ab7679f258b30

gopherbot · 2020-03-21T04:10:14Z

Change https://golang.org/cl/224677 mentions this issue: tools/gopls: add cmd support for workspace_symbol

This change adds command line support for workspace/symbol. Symbols are formatted as '{span} {name} {type}'. $ gopls workspace_symbol -matcher fuzzy 'wsymbols' $ $ workspacesymbol/a/a.go:5:7-31 WorkspaceSymbolConstantA Constant $ workspacesymbol/b/b.go:5:6-28 WorkspaceSymbolStructB Struct Optional arguments are: -matcher, which specifies the type of matcher: fuzzy, caseSensitive, or caseInsensitive. The default is caseInsensitive. Updates golang/go#32875 Change-Id: Ieef443b13710f9c973210e58f66ab7679f258b30 Reviewed-on: https://go-review.googlesource.com/c/tools/+/224677 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>

mattheusv · 2021-01-06T22:12:59Z

Anyone is working on Completion? If not I can try to implement.

stamblerre · 2021-01-07T18:11:00Z

No, I don't believe anyone has worked on completion, so please feel free to work on it.

findleyr · 2022-07-15T14:30:11Z

Circling back, I don't think we should do this.

Supporting features on the command line has a real cost:

we need to implement and maintain versions of our test runner for each feature
we increase our API surface area

But on the other hand, I never see requests for additional command-line features. So absent specific requests, I think we should not change the CLI.

Tentatively closing this issue as it doesn't seem actionable. If you are reading this and wish that gopls had a specific command-line feature, please file a separate issue.

gopherbot added this to the Unreleased milestone Jul 1, 2019

gopherbot added the gopls Issues related to the Go language server, gopls. label Jul 1, 2019

stamblerre mentioned this issue Jul 1, 2019

x/tools/cmd/gorename: doesn't work outside $GOPATH #27571

Closed

stamblerre added Suggested Issues that may be good for new contributors looking for work to do. NeedsFix The path to resolution is known, but the work has not been done. labels Jul 10, 2019

stamblerre added help wanted and removed Suggested Issues that may be good for new contributors looking for work to do. labels Aug 8, 2019

hartzell mentioned this issue Sep 11, 2019

tools/gopls: add command line support for rename golang/tools#157

Closed

kalmanb mentioned this issue Oct 21, 2019

tools/gopls: add command line support for suggestedfix golang/tools#174

Closed

kalmanb mentioned this issue Oct 22, 2019

tools/gopls: add command line support for imports golang/tools#176

Closed

kalmanb mentioned this issue Oct 24, 2019

tools/gopls: add command line support for links golang/tools#181

Closed

gertcuykens mentioned this issue Oct 28, 2019

cmd/doc: support -mod=readonly and other build flags #35200

Open

rhnvrm added a commit to rhnvrm/tools that referenced this issue Nov 25, 2019

tools/gopls: add cmd support for prepare_rename

9a8bd3b

Updates golang/go#32875

stamblerre modified the milestones: Unreleased, gopls v1.0 Dec 4, 2019

rhnvrm added a commit to rhnvrm/tools that referenced this issue Jan 23, 2020

tools/gopls: add cmd support for prepare_rename

d4de61b

Updates golang/go#32875

rhnvrm added a commit to rhnvrm/tools that referenced this issue Jan 24, 2020

tools/gopls: add cmd support for prepare_rename

571a89b

Updates golang/go#32875

rhnvrm added a commit to rhnvrm/tools that referenced this issue Jan 31, 2020

tools/gopls: add cmd support for prepare_rename

176b6cd

Updates golang/go#32875

rhnvrm added a commit to rhnvrm/tools that referenced this issue Feb 4, 2020

tools/gopls: add cmd support for prepare_rename

118e846

Updates golang/go#32875

stamblerre mentioned this issue Mar 12, 2020

x/tools/gopls: support workspace/Symbol request #33844

Closed

stamblerre removed this from the gopls/v1.0.0 milestone Jun 24, 2020

stamblerre added this to the gopls/unplanned milestone Oct 21, 2020

findleyr closed this as completed Jul 15, 2022

findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2022

golang locked and limited conversation to collaborators Aug 14, 2023

gopherbot added the FrozenDueToAge label Aug 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/tools/gopls: support all features on the command line #32875

x/tools/gopls: support all features on the command line #32875

stamblerre commented Jul 1, 2019

hartzell commented Sep 6, 2019

hartzell commented Sep 20, 2019

rentziass commented Oct 16, 2019

stamblerre commented Oct 16, 2019

kalmanb commented Oct 17, 2019

stamblerre commented Oct 17, 2019

kalmanb commented Oct 18, 2019

gopherbot commented Oct 19, 2019

gopherbot commented Oct 21, 2019

kalmanb commented Oct 22, 2019

gopherbot commented Oct 22, 2019

rentziass commented Oct 23, 2019

gopherbot commented Oct 24, 2019

gopherbot commented Oct 27, 2019

gopherbot commented Oct 29, 2019

jbszczepaniak commented Nov 22, 2019 •

edited

Loading

rentziass commented Nov 22, 2019

jbszczepaniak commented Nov 22, 2019 •

edited

Loading

stamblerre commented Nov 22, 2019

rentziass commented Nov 22, 2019

jbszczepaniak commented Nov 22, 2019 via email

daisuzu commented Mar 14, 2020

gopherbot commented Mar 21, 2020

mattheusv commented Jan 6, 2021

stamblerre commented Jan 7, 2021

findleyr commented Jul 15, 2022

x/tools/gopls: support all features on the command line #32875

x/tools/gopls: support all features on the command line #32875

Comments

stamblerre commented Jul 1, 2019

hartzell commented Sep 6, 2019

hartzell commented Sep 20, 2019

rentziass commented Oct 16, 2019

stamblerre commented Oct 16, 2019

kalmanb commented Oct 17, 2019

stamblerre commented Oct 17, 2019

kalmanb commented Oct 18, 2019

gopherbot commented Oct 19, 2019

gopherbot commented Oct 21, 2019

kalmanb commented Oct 22, 2019

gopherbot commented Oct 22, 2019

rentziass commented Oct 23, 2019

gopherbot commented Oct 24, 2019

gopherbot commented Oct 27, 2019

gopherbot commented Oct 29, 2019

jbszczepaniak commented Nov 22, 2019 • edited Loading

rentziass commented Nov 22, 2019

jbszczepaniak commented Nov 22, 2019 • edited Loading

stamblerre commented Nov 22, 2019

rentziass commented Nov 22, 2019

jbszczepaniak commented Nov 22, 2019 via email

daisuzu commented Mar 14, 2020

gopherbot commented Mar 21, 2020

mattheusv commented Jan 6, 2021

stamblerre commented Jan 7, 2021

findleyr commented Jul 15, 2022

jbszczepaniak commented Nov 22, 2019 •

edited

Loading

jbszczepaniak commented Nov 22, 2019 •

edited

Loading