Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: -failfast flag does not apply across packages #33038

Closed
dsnet opened this issue Jul 10, 2019 · 8 comments
Closed

cmd/go: -failfast flag does not apply across packages #33038

dsnet opened this issue Jul 10, 2019 · 8 comments
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. GoCommand cmd/go help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.23

Comments

@dsnet
Copy link
Member

dsnet commented Jul 10, 2019

Using go1.12

The documentation for failfast says "Do not start new tests after the first test failure."

When running go test ./... -failfast and one of the packages has a failure, it continues to run the tests for other packages. My interpretation of the documentation above is that go test would stop after any failure, even if in a different package.
@dmitshur dmitshur added GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 15, 2019
@dmitshur dmitshur added this to the Go1.14 milestone Jul 15, 2019
@dmitshur dmitshur changed the title testing: failfast flags does not apply across packages cmd/go: -failfast flag does not apply across packages Jul 15, 2019
@dmitshur
Copy link
Contributor

/cc @jayconrod @bcmills

@zenovich
Copy link

zenovich commented Jul 23, 2019 •
edited

For now, this command helps me a lot:

for s in $(go list ./...); do if ! go test -failfast -v -p 1 $s; then break; fi; done

@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@dnephin dnephin mentioned this issue Nov 8, 2020
Merged
@Rustin170506 Rustin170506 mentioned this issue Aug 19, 2021
Closed
@lookfirst

This comment was marked as duplicate.

Sign in to view
@seankhliao seankhliao mentioned this issue Feb 8, 2022
Closed
@my-git9 my-git9 mentioned this issue Jun 29, 2022
Merged
@docmerlin

This comment was marked as duplicate.

Sign in to view
@mvdan
Copy link
Member

mvdan commented Jul 27, 2022

Please refrain from "bumping" github threads; see https://github.com/golang/go/wiki/NoPlusOne. If you would like to speed up the resolution of this issue, you can either react with a 👍 on the original post, or look into sending a CL with a test. See https://go.dev/doc/contribute :)

@dnephin dnephin mentioned this issue Oct 2, 2022
Merged
kerzhner added a commit to statechannels/go-nitro that referenced this issue Mar 23, 2023
@kerzhner
Fail inegration tests after first failure
a298b0f 
Note that the flag will stop future tests for a failing package.
But tests for other packages will continue. See
golang/go#33038
@kerzhner kerzhner mentioned this issue Mar 23, 2023
Merged
kerzhner added a commit to statechannels/go-nitro that referenced this issue Mar 24, 2023
@kerzhner
Fail inegration tests after first failure
4d27096 
Note that the flag will stop future tests for a failing package.
But tests for other packages will continue. See
golang/go#33038
@bcmills bcmills mentioned this issue Jun 27, 2023
Open
bendrucker added a commit to observeinc/terraform-provider-observe that referenced this issue Jul 26, 2023
@bendrucker
test: run go test with -failfast
334ccf3 
Run `go test` to exit as soon as one test fails. While this may mean the test you care about never runs, it's better than waiting for a whole suite after one flake:

Since all our acceptance tests are in one package `-failfast` should work:

golang/go#33038
@bendrucker bendrucker mentioned this issue Jul 26, 2023
Merged
AlexanderYastrebov added a commit to AlexanderYastrebov/go that referenced this issue Sep 18, 2023
@AlexanderYastrebov
cmd/go: fail fast across packages
3390b23 
Fixes golang#33038
@AlexanderYastrebov AlexanderYastrebov mentioned this issue Sep 18, 2023
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/529198 mentions this issue: cmd/go: fail fast across packages

AlexanderYastrebov added a commit to AlexanderYastrebov/go that referenced this issue Sep 25, 2023
@AlexanderYastrebov
cmd/go: fail fast across packages
ef4d81c 
Fixes golang#33038
AlexanderYastrebov added a commit to AlexanderYastrebov/go that referenced this issue Sep 25, 2023
@AlexanderYastrebov
cmd/go: fail fast across packages
b9faf0d 
Fixes golang#33038
AlexanderYastrebov added a commit to AlexanderYastrebov/go that referenced this issue Dec 10, 2023
@AlexanderYastrebov
cmd/go: fail fast across packages
3fe6fd5 
Fixes golang#33038
@AlexanderYastrebov
Copy link
Contributor

Bump :)

AlexanderYastrebov added a commit to AlexanderYastrebov/go that referenced this issue Feb 8, 2024
@AlexanderYastrebov
cmd/go: fail fast across packages
14bb5cd 
Fixes golang#33038
@AlexanderYastrebov
Copy link
Contributor

Please refrain from "bumping" github threads

@mvdan @bcmills @dsnet How do I bring attention back? PR is ready since October 2023

@dmitshur dmitshur added the FixPending Issues that have a fix which has not yet been reviewed or submitted. label Feb 8, 2024
AlexanderYastrebov added a commit to AlexanderYastrebov/go that referenced this issue Feb 17, 2024
@AlexanderYastrebov
cmd/go: fail fast across packages
302ebd6 
Fixes golang#33038
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Feb 17, 2024
@dmitshur dmitshur modified the milestones: Backlog, Go1.23 Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. GoCommand cmd/go help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.23
Development

Successfully merging a pull request may close this issue.

cmd/go: fail fast across packages AlexanderYastrebov/go
10 participants
@lookfirst @rsc @zenovich @AlexanderYastrebov @docmerlin @dmitshur @mvdan @bcmills @dsnet @gopherbot