Fail CI unit tests after first failure #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the flag will stop future tests for a failing package. But tests for other packages will continue. See golang/go#33038
✅ Deploy Preview for nitrodocs canceled.
|
lalexgap
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a test for a package fails, no more tests are run for the package. But tests for other packages will continue. See
golang/go#33038.
For now, this is good enough. The main issue we are seeing is flickering of
client_testunit tests. As soon as aclient_testtest fails, no more tests for theclient_testpackage will run. So logs with the failing test will not be overwritten.